Skip to content

Commit eb7022f

Browse files
Copilotxperiandri
andauthored
Refactor repeated friends index access in remote provider tests
Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/79103f2d-049f-4772-91c8-b1fc8f9d2000 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>
1 parent 26c0f41 commit eb7022f

1 file changed

Lines changed: 30 additions & 22 deletions

File tree

tests/FSharp.Data.GraphQL.IntegrationTests/SwapiRemoteProviderTests.fs

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,21 @@ hero (id: "1000") {
5252
result.Data.Value.Hero.Value.AppearsIn |> equals [| Episode.NewHope; Episode.Empire; Episode.Jedi |]
5353
let friends = result.Data.Value.Hero.Value.Friends.Edges |> Array.map (fun e -> e.Node)
5454
friends.Length |> equals 4
55-
friends[0].IsHuman() |> equals true
56-
friends[0].AsHuman().Name |> equals (Some "Han Solo")
57-
friends[1].IsHuman() |> equals true
58-
friends[1].AsHuman().Name |> equals (Some "Leia Organa")
59-
friends[1].AsHuman().HomePlanet |> equals (Some "Alderaan")
60-
friends[2].IsDroid() |> equals true
61-
friends[2].AsDroid().Name |> equals (Some "C-3PO")
62-
friends[2].AsDroid().PrimaryFunction |> equals (Some "Protocol")
63-
friends[3].IsDroid() |> equals true
64-
friends[3].AsDroid().Name |> equals (Some "R2-D2")
65-
friends[3].AsDroid().PrimaryFunction |> equals (Some "Astromech")
55+
let friend0 = friends[0]
56+
friend0.IsHuman() |> equals true
57+
friend0.AsHuman().Name |> equals (Some "Han Solo")
58+
let friend1 = friends[1]
59+
friend1.IsHuman() |> equals true
60+
friend1.AsHuman().Name |> equals (Some "Leia Organa")
61+
friend1.AsHuman().HomePlanet |> equals (Some "Alderaan")
62+
let friend2 = friends[2]
63+
friend2.IsDroid() |> equals true
64+
friend2.AsDroid().Name |> equals (Some "C-3PO")
65+
friend2.AsDroid().PrimaryFunction |> equals (Some "Protocol")
66+
let friend3 = friends[3]
67+
friend3.IsDroid() |> equals true
68+
friend3.AsDroid().Name |> equals (Some "R2-D2")
69+
friend3.AsDroid().PrimaryFunction |> equals (Some "Astromech")
6670
result.Data.Value.Hero.Value.HomePlanet |> equals (Some "Tatooine")
6771
let actual = normalize <| sprintf "%A" result.Data
6872
let expected = normalize <| """Some
@@ -180,17 +184,21 @@ module FileOperation =
180184
result.Data.Value.Hero.Value.AppearsIn |> equals [| Episode.NewHope; Episode.Empire; Episode.Jedi |]
181185
let friends = result.Data.Value.Hero.Value.Friends.Edges |> Array.map _.Node
182186
friends.Length |> equals 4
183-
friends[0].IsHuman() |> equals true
184-
friends[0].AsHuman().Name |> equals (Some "Han Solo")
185-
friends[1].IsHuman() |> equals true
186-
friends[1].AsHuman().Name |> equals (Some "Leia Organa")
187-
friends[1].AsHuman().HomePlanet |> equals (Some "Alderaan")
188-
friends[2].IsDroid() |> equals true
189-
friends[2].AsDroid().Name |> equals (Some "C-3PO")
190-
friends[2].AsDroid().PrimaryFunction |> equals (Some "Protocol")
191-
friends[3].IsDroid() |> equals true
192-
friends[3].AsDroid().Name |> equals (Some "R2-D2")
193-
friends[3].AsDroid().PrimaryFunction |> equals (Some "Astromech")
187+
let friend0 = friends[0]
188+
friend0.IsHuman() |> equals true
189+
friend0.AsHuman().Name |> equals (Some "Han Solo")
190+
let friend1 = friends[1]
191+
friend1.IsHuman() |> equals true
192+
friend1.AsHuman().Name |> equals (Some "Leia Organa")
193+
friend1.AsHuman().HomePlanet |> equals (Some "Alderaan")
194+
let friend2 = friends[2]
195+
friend2.IsDroid() |> equals true
196+
friend2.AsDroid().Name |> equals (Some "C-3PO")
197+
friend2.AsDroid().PrimaryFunction |> equals (Some "Protocol")
198+
let friend3 = friends[3]
199+
friend3.IsDroid() |> equals true
200+
friend3.AsDroid().Name |> equals (Some "R2-D2")
201+
friend3.AsDroid().PrimaryFunction |> equals (Some "Astromech")
194202
result.Data.Value.Hero.Value.HomePlanet |> equals (Some "Tatooine")
195203
let actual = normalize <| sprintf "%A" result.Data
196204
let expected = normalize <| """Some

0 commit comments

Comments
 (0)