Address review feedback on literals and documentId hashing

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/5d78ecae-85c3-42af-9ad0-1750b8aa7fff

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Author: Copilot

Packages.props

@@ -17,6 +17,7 @@
     </PackageReference>
     <PackageReference Update="FSharp.Control.FusionTasks" Version="2.6.*" />
     <PackageReference Update="FSharp.Control.Reactive" Version="6.*" />
+    <PackageReference Update="FSharp.Data.LiteralProviders" Version="1.0.3" />
     <PackageReference Update="FSharp.SystemTextJson" Version="1.*" />
     <PackageReference Update="FsToolkit.ErrorHandling" Version="$(FsToolkitVersion)" />
     <PackageReference Update="FsToolkit.ErrorHandling.TaskResult" Version="$(FsToolkitVersion)" />

src/FSharp.Data.GraphQL.Server/Executor.fs

@@ -83,12 +83,18 @@ type Executor<'Root>(schema: ISchema<'Root>, middlewares : IExecutorMiddleware s
     let middlewaresList = Seq.toList middlewares
 
     /// Generates a deterministic document identifier from the canonical query string.
-    /// The SHA-256 hash is truncated to 32 bits to preserve the existing int32 documentId contract.
+    /// The full SHA-256 hash is folded into 32 bits to preserve the existing int32 documentId contract.
     let getDocumentId (document : Document) =
         let canonicalQuery = document.ToQueryString()
         let queryBytes = Encoding.UTF8.GetBytes canonicalQuery
         let hash = SHA256.HashData queryBytes
-        BinaryPrimitives.ReadInt32BigEndian(hash.AsSpan(0, 4))
+        [ 0 .. 7 ]
+        |> List.fold
+            (fun acc index ->
+                let start = index * 4
+                let hashChunk = BinaryPrimitives.ReadInt32BigEndian(hash.AsSpan(start, 4))
+                acc ^^^ hashChunk)
+            0
 
     let rec runMiddlewares (phaseSel : IExecutorMiddleware -> ('ctx -> ('ctx -> 'res) -> 'res) option)
                            (initialCtx : 'ctx)

tests/FSharp.Data.GraphQL.IntegrationTests/integration-introspection.json

@@ -1,5 +1,5 @@
 {
-  "documentId": 1417518537,
+  "documentId": 1890859023,
   "data": {
     "__schema": {
       "queryType": {

tests/FSharp.Data.GraphQL.IntegrationTests/introspection.json

@@ -1,5 +1,5 @@
 {
-  "documentId": 1417518537,
+  "documentId": 1890859023,
   "data": {
     "__schema": {
       "queryType": {

tests/FSharp.Data.GraphQL.Tests/ExecutionTests.fs

@@ -385,9 +385,9 @@ let ``Execution when querying returns unique document id with response`` () =
                 ]))
     let query = "query Example { a, b, a }"
     // Deterministic SHA-256-based documentId for canonical `query Example { a b a }`,
-    // using the first 4 bytes of the hash as a big-endian int32.
+    // folding all 32 hash bytes into an int32 via 8 big-endian chunks.
     // Computed once via parse + ToQueryString + SHA-256 and kept fixed to catch regressions.
-    let expectedDocumentId = -2063861555
+    let expectedDocumentId = 154204461
     let result1 = sync <| Executor(schema).AsyncExecute(query, getMockInputContext, { A = "aa"; B = 2 })
     let result2 = sync <| Executor(schema).AsyncExecute(query, getMockInputContext, { A = "aa"; B = 2 })
     result1.DocumentId |> notEquals Unchecked.defaultof<int>

tests/FSharp.Data.GraphQL.Tests/FSharp.Data.GraphQL.Tests.fsproj

@@ -16,6 +16,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Cosmos" />
+    <PackageReference Include="FSharp.Data.LiteralProviders" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="BenchmarkDotNet" />
     <PackageReference Include="Validus" />