Skip to content

Commit 3884515

Browse files
authored
Merge pull request #1745 from fsprojects/repo-assist/improve-sha1-disposal-caching-2026-04-16-f466c854a7d11c78
[Repo Assist] fix: dispose SHA1 instance in Caching.hashString; use SHA1.HashData on .NET 5+
2 parents 3b05c1e + 2dd182c commit 3884515

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

src/FSharp.Data.Runtime.Utilities/Caching.fs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,15 @@ let createInMemoryCache (expiration: TimeSpan) =
5555
/// Get hash code of a string - used to determine cache file
5656
let private hashString (plainText: string) =
5757
let plainTextBytes = Encoding.UTF8.GetBytes(plainText)
58-
let hashBytes = SHA1.Create().ComputeHash(plainTextBytes)
58+
59+
let hashBytes =
60+
#if NET5_0_OR_GREATER
61+
SHA1.HashData(plainTextBytes)
62+
#else
63+
use sha1 = SHA1.Create()
64+
sha1.ComputeHash(plainTextBytes)
65+
#endif
66+
5967
let s = Convert.ToBase64String(hashBytes)
6068
s.Replace("ab", "abab").Replace("\\", "ab")
6169

0 commit comments

Comments
 (0)