Skip to content

Commit 5e334d2

Browse files
eng: remove AssemblyInfo files; use SDK-generated assembly attributes
- Delete all src/AssemblyInfo*.fs files (FAKE-generated, legacy approach) - Delete tests/.../Properties/AssemblyInfo.cs (unused dead code) - Remove GenerateAssemblyInfo=false and Compile includes from all .fsproj files - Add Product and AssemblyDescription to Directory.Build.props (shared values) - Pass Version to the Build MSBuild step so assemblies get the right version - Remove AssemblyInfo FAKE target and dep from build pipeline - Remove Fake.DotNet.AssemblyInfoFile from build/paket.references - Bump version to 8.1.14 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent e3e318a commit 5e334d2

23 files changed

Lines changed: 10 additions & 234 deletions

Directory.Build.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
<PackageProjectUrl>https://fsprojects.github.io/FSharp.Data</PackageProjectUrl>
1212
<PackageIconUrl>https://raw.githubusercontent.com/fsprojects/FSharp.Data/master/docs/img/logo.png</PackageIconUrl>
1313
<RepositoryType>git</RepositoryType>
14+
<Product>FSharp.Data</Product>
15+
<AssemblyDescription>Library of F# type providers and data access tools</AssemblyDescription>
1416
<SignAssembly>true</SignAssembly>
1517
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\keyfile.snk</AssemblyOriginatorKeyFile>
1618
<PublicSign>false</PublicSign>

RELEASE_NOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Release Notes
22

3+
## 8.1.14 - May 09 2026
4+
5+
- Eng: Remove manual `AssemblyInfo*.fs` files; use SDK-generated assembly attributes instead.
6+
37
## 8.1.13 - May 08 2026
48

59
- Performance: `HtmlNode.serialize` no longer allocates a temporary `string` on each newline/indentation step; uses `StringBuilder.Append(char, int)` overload directly. `isVoidElement` set is now computed once at module initialisation instead of being re-created on every `HtmlNode.ToString()` call. `HtmlDocument.ToString()` uses a single `StringBuilder` for the whole document instead of `List.map … |> String.Concat`.

build/build.fs

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ let buildscript () =
2020
(!!includes).SetBaseDirectory(__SOURCE_DIRECTORY__ </> "..")
2121

2222
// --------------------------------------------------------------------------------------
23-
// Information about the project to be used at NuGet and in AssemblyInfo files
23+
// Information about the project to be used at NuGet
2424
// --------------------------------------------------------------------------------------
2525

2626
let project = "FSharp.Data"
@@ -56,27 +56,6 @@ let buildscript () =
5656

5757
let isCI = Environment.GetEnvironmentVariable("CI") <> null
5858

59-
// --------------------------------------------------------------------------------------
60-
// Generate assembly info files with the right version & up-to-date information
61-
62-
Target.create "AssemblyInfo" (fun _ ->
63-
for file in !!"src/AssemblyInfo*.fs" do
64-
let replace (oldValue: string) newValue (str: string) = str.Replace(oldValue, newValue)
65-
66-
let title =
67-
Path.GetFileNameWithoutExtension file |> replace "AssemblyInfo" "FSharp.Data"
68-
69-
let versionSuffix = ".0"
70-
let version = release.AssemblyVersion + versionSuffix
71-
72-
AssemblyInfoFile.createFSharp
73-
file
74-
[ AssemblyInfo.Title title
75-
AssemblyInfo.Product project
76-
AssemblyInfo.Description summary
77-
AssemblyInfo.Version version
78-
AssemblyInfo.FileVersion version ])
79-
8059
// --------------------------------------------------------------------------------------
8160
// Clean build results
8261

@@ -110,6 +89,7 @@ let buildscript () =
11089
Configuration = DotNet.BuildConfiguration.Release
11190
MSBuildParams =
11291
{ o.MSBuildParams with
92+
Properties = [ ("Version", release.NugetVersion) ]
11393
DisableInternalBinLog = true } }))
11494

11595
Target.create "RunTests" (fun _ ->
@@ -217,9 +197,7 @@ let buildscript () =
217197
printfn "")
218198

219199
let sourceFiles =
220-
!!"src/**/*.fs" ++ "src/**/*.fsi" ++ "build/build.fs"
221-
-- "src/**/obj/**/*.fs"
222-
-- "src/AssemblyInfo*.fs"
200+
!!"src/**/*.fs" ++ "src/**/*.fsi" ++ "build/build.fs" -- "src/**/obj/**/*.fs"
223201

224202
Target.create "Format" (fun _ ->
225203
let result =
@@ -267,7 +245,7 @@ let buildscript () =
267245

268246
Target.create "All" ignore
269247

270-
"Clean" ==> "AssemblyInfo" ==> "CheckFormat" ==> "Build"
248+
"Clean" ==> "CheckFormat" ==> "Build"
271249

272250
"Build" ==> "CleanDocs" ==> "GenerateDocs" ==> "All"
273251

build/paket.references

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ group Fake
1212
Fake.Core.Tasks
1313
Fake.Core.Target
1414
Fake.Core.ReleaseNotes
15-
Fake.DotNet.AssemblyInfoFile
1615
Fake.DotNet.Cli
1716
Fake.DotNet.Testing.NUnit
1817
Fake.DotNet.NuGet

src/AssemblyInfo.Csv.Core.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AssemblyInfo.DesignTime.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AssemblyInfo.Html.Core.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AssemblyInfo.Http.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AssemblyInfo.Json.Core.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/AssemblyInfo.Runtime.Utilities.fs

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)