Merge branch 'main' into repo-assist/fix-issue-1251-http-response-default-utf8-rebase-9c637d7c2e08fb9f

Author: dsyme

.github/aw/actions-lock.json

@@ -10,15 +10,15 @@
       "version": "v8",
       "sha": "ed597411d8f924073f98dfc5c65a23a2325f34cd"
     },
-    "github/gh-aw-actions/setup@v0.64.3": {
+    "github/gh-aw-actions/setup@v0.65.4": {
       "repo": "github/gh-aw-actions/setup",
-      "version": "v0.64.3",
-      "sha": "84dc9c12e0d955a200911a3a07c3f5dd96a175d7"
+      "version": "v0.65.4",
+      "sha": "934698b44320d87a7a9196339f90293f10bd2247"
     },
-    "github/gh-aw/actions/setup@v0.64.3": {
+    "github/gh-aw/actions/setup@v0.65.4": {
       "repo": "github/gh-aw/actions/setup",
-      "version": "v0.64.3",
-      "sha": "7a91ad396dfe21b7c462b59b6aecd4680815c419"
+      "version": "v0.65.4",
+      "sha": "b5a9fb08751b738a86b3b605ff1fdf34956adbf4"
     }
   }
 }

.github/workflows/repo-assist.lock.yml

@@ -57,10 +57,10 @@ tools:
 
 safe-outputs:
   messages:
-    footer: "> Generated by 🌈 Repo Assist at [{run-started}]({run_url}). [Learn more](https://github.com/githubnext/agentics/blob/main/docs/repo-assist.md)."
-    run-started: "Repo Assist is processing {event_type}, started at at [{run-started}]({run_url})..."
-    run-success: "✓ Repo Assist completed successfully at {run-ended}."
-    run-failure: "✗ Repo Assist encountered {status} at {run-ended}."
+    footer: "> Generated by 🌈 {workflow_name}, see [workflow run]({run_url}). [Learn more](https://github.com/githubnext/agentics/blob/main/docs/repo-assist.md)."
+    run-started: "{workflow_name} is processing {event_type}, see [workflow run]({run_url})..."
+    run-success: "✓ {workflow_name} completed successfully, see [workflow run]({run_url})."
+    run-failure: "✗ {workflow_name} encountered {status}, see [workflow run]({run_url})."
   add-comment:
     max: 10
     target: "*"
@@ -185,7 +185,7 @@ steps:
           json.dump(result, f, indent=2)
       EOF
 
-source: githubnext/agentics/workflows/repo-assist.md@1f672aef974f4246124860fc532f82fe8a93a57e
+source: githubnext/agentics/workflows/repo-assist.md@e1ecf341a90b7bc2021e77c58685d7e269e20b99
 ---
 
 # Repo Assist

.github/workflows/repo-assist.md

@@ -1,9 +1,13 @@
 # Release Notes
 
-## 8.1.4 - Apr 01 2026
+## 9.0.0 - Apr 01 2026
 
 - Change HTTP response default encoding from ISO-8859-1 to UTF-8 to match `System.Net.Http.HttpClient` behaviour (closes #1251)
 
+## 8.1.4 - Mar 30 2026
+
+- Performance: `JsonValue.Parse` now copies unescaped string runs in bulk instead of appending character-by-character, reducing `StringBuilder.Append` calls for strings with few or no escape sequences
+
 ## 8.1.3 - Mar 23 2026
 
 - Fix JSON `/* ... */` comment parser: `*` or `/` characters inside the comment body no longer cause premature termination and parse failure

RELEASE_NOTES.md

@@ -123,6 +123,32 @@ let buildscript () =
 
         "FSharp.Data.sln" |> DotNet.test setParams)
 
+    // --------------------------------------------------------------------------------------
+    // Run tests with code coverage (uses Coverlet collector already present in test projects)
+
+    Target.create "Coverage" (fun _ ->
+        let setParams (o: DotNet.TestOptions) =
+            { o with
+                Configuration = DotNet.BuildConfiguration.Release
+                Collect = Some "XPlat Code Coverage"
+                ResultsDirectory = Some "coverage-results"
+                MSBuildParams =
+                    { o.MSBuildParams with
+                        DisableInternalBinLog = true }
+                Logger = if isCI then Some "GitHubActions" else None }
+
+        "FSharp.Data.sln" |> DotNet.test setParams
+
+        Trace.log ""
+        Trace.log "Coverage results written to ./coverage-results/"
+        Trace.log "To generate an HTML report, install dotnet-reportgenerator-globaltool:"
+        Trace.log "  dotnet tool install -g dotnet-reportgenerator-globaltool"
+
+        Trace.log
+            "  reportgenerator -reports:coverage-results/**/coverage.cobertura.xml -targetdir:coverage-report -reporttypes:Html"
+
+        Trace.log "")
+
     // --------------------------------------------------------------------------------------
     // Build packages
 
@@ -179,6 +205,7 @@ let buildscript () =
         printfn "  Targets for building:"
         printfn "  * Build"
         printfn "  * RunTests"
+        printfn "  * Coverage (run tests with Coverlet code coverage; results in ./coverage-results/)"
         printfn "  * GenerateDocs"
         printfn "  * Pack (creates package only, doesn't publish)"
         printfn "  * All (calls previous 5)"
@@ -247,6 +274,7 @@ let buildscript () =
     "Build" ==> "Pack" ==> "All"
     "Build" ==> "All"
     "Build" ==> "RunTests" ==> "All"
+    "Build" ==> "Coverage"
     "Build" ==> "RunBenchmarks"
 
 [<EntryPoint>]

build/build.fs

@@ -100,15 +100,19 @@ let internal convertJsonValue
                     (<@ (%varExpr).Path() @>, convert <@ Some (%varExpr).JsonValue @>, <@ Some (%varExpr).JsonValue @>))
         | TypeWrapper.Option, true -> convert <@ (%%value: JsonValue option) @>
         | TypeWrapper.Option, false ->
-            //TODO: not covered in tests
+            // Reached when canPassAllConversionCallingTypes=false (e.g. for array element types or
+            // heterogeneous type variants). The caller passes an IJsonDocument; we extract its
+            // JsonValue and wrap it in Some before handing it to the conversion quotation.
             convert <@ Some (%%value: IJsonDocument).JsonValue @>
         | TypeWrapper.Nullable, true ->
-            //TODO: not covered in tests
+            // TypeWrapper.Nullable is never produced by JSON inference (which only emits None or Option).
+            // This branch exists for structural completeness and potential future extensibility.
             typeof<TextRuntime>?(nameof (TextRuntime.OptionToNullable))
                 (field.RuntimeType)
                 (convert <@ (%%value: JsonValue option) @>)
         | TypeWrapper.Nullable, false ->
-            //TODO: not covered in tests
+            // TypeWrapper.Nullable is never produced by JSON inference (which only emits None or Option).
+            // This branch exists for structural completeness and potential future extensibility.
             typeof<TextRuntime>?(nameof (TextRuntime.OptionToNullable))
                 (field.RuntimeType)
                 (convert <@ Some (%%value: IJsonDocument).JsonValue @>)

src/FSharp.Data.DesignTime/Json/JsonConversionsGenerator.fs

@@ -632,7 +632,12 @@ module JsonTypeBuilder =
 
                                       match propResult.OptionalConverter with
                                       | Some _ ->
-                                          //TODO: not covered in tests
+                                          // Reached when a property is optional (IsOptional=true) but its
+                                          // ConversionCallingType is JsonDocument (optionalityHandledByProperty=false),
+                                          // meaning the property type has a converter but optionality is not handled
+                                          // by the conversion calling type alone. In practice this requires an
+                                          // InferedType.Json(optional=true) property, which the JSON provider does
+                                          // not currently produce.
                                           ctx.JsonRuntimeType?(nameof (JsonRuntime.ConvertOptionalProperty))
                                               (propResult.ConvertedTypeErased ctx)
                                               (jDoc, propName, propResult.ConverterFunc ctx)

src/FSharp.Data.DesignTime/Json/JsonGenerator.fs

@@ -315,8 +315,18 @@ type private JsonParser(jsonText: string) =
         ensure (i < s.Length && s.[i] = '"')
         i <- i + 1
 
+        // Track start of current unescaped run; flush as a bulk chunk when an escape or end is hit.
+        // This avoids per-character StringBuilder.Append calls for strings with few/no escapes,
+        // which is the common case in real-world JSON.
+        let mutable chunkStart = i
+
+        let inline flushChunk upTo =
+            if upTo > chunkStart then
+                buf.Append(s, chunkStart, upTo - chunkStart) |> ignore
+
         while i < s.Length && s.[i] <> '"' do
             if s.[i] = '\\' then
+                flushChunk i
                 ensure (i + 1 < s.Length)
 
                 match s.[i + 1] with
@@ -371,10 +381,12 @@ type private JsonParser(jsonText: string) =
                 | _ -> throw ()
 
                 i <- i + 2 // skip past \ and next char
+                chunkStart <- i
             else
-                buf.Append(s.[i]) |> ignore
                 i <- i + 1
 
+        // Flush any remaining unescaped characters
+        flushChunk i
         ensure (i < s.Length && s.[i] = '"')
         i <- i + 1
         let str = buf.ToString()