Skip to content

Commit ad38529

Browse files
authored
Merge pull request #1773 from fsprojects/repo-assist/eng-fix-netsdk1212-trimmable-2026-05-03-a7bb74b711e43652
[Repo Assist] eng: suppress NETSDK1212 warnings by conditioning IsTrimmable on net6.0+
2 parents 6f2ff52 + 0dc7a81 commit ad38529

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/FSharp.Data.Csv.Core/FSharp.Data.Csv.Core.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="CsvRuntime.fs" />

src/FSharp.Data.Html.Core/FSharp.Data.Html.Core.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
<DefineConstants>$(DefineConstants);HIDE_REPRESENTATION</DefineConstants>
1414
</PropertyGroup>
1515
<ItemGroup>

src/FSharp.Data.Http/FSharp.Data.Http.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="Http.fs" />

src/FSharp.Data.Json.Core/FSharp.Data.Json.Core.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="JsonValue.fs" />

src/FSharp.Data.Runtime.Utilities/FSharp.Data.Runtime.Utilities.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="PublicApi.fs" />

src/FSharp.Data.WorldBank.Core/FSharp.Data.WorldBank.Core.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="WorldBankRuntime.fs" />

src/FSharp.Data.Xml.Core/FSharp.Data.Xml.Core.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIcon>logo.png</PackageIcon>
1010
<!-- always have tailcalls on for design time compiler add-in to allow repo to compile in DEBUG, see https://github.com/fsprojects/FSharp.Data/issues/1410 -->
1111
<Tailcalls>true</Tailcalls>
12-
<IsTrimmable>true</IsTrimmable>
12+
<IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
1313
</PropertyGroup>
1414
<ItemGroup>
1515
<Compile Include="XmlRuntime.fs" />

0 commit comments

Comments
 (0)