Skip to content

Commit af60d03

Browse files
authored
Merge branch 'main' into repo-assist/fix-issue-1251-http-response-default-utf8-ba30ad37ff9bf8f6
2 parents dbaa6cf + e0f2473 commit af60d03

10 files changed

Lines changed: 50 additions & 207 deletions

File tree

.github/workflows/repo-assist.lock.yml

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/repo-assist.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ tools:
7676
bash: true
7777
repo-memory: true
7878

79-
source: githubnext/agentics/workflows/repo-assist.md@69c1ee19e39e6aaba35519aafefb5cbf314de323
79+
source: githubnext/agentics/workflows/repo-assist.md@afb00b92a9514fee9a14c583f059a03d05738f70
8080
---
8181

8282
# Repo Assist
@@ -137,12 +137,12 @@ Always do Task 11 (Update Monthly Activity Summary Issue) every run. In all comm
137137
### Task 1: Triage and Comment on Open Issues
138138

139139
1. List open issues sorted by creation date ascending (oldest first). Resume from your memory's backlog cursor; reset when you reach the end.
140-
2. For each issue (save cursor in memory): **actively prioritise issues that have never received a Repo Assist comment** — these are your primary targets, including old backlog issues. Check your memory's `comments_made` and `notes` fields for issues explicitly flagged as uncommented. Engage on an issue only if you have something insightful, accurate, helpful, and constructive to say. Expect to engage substantively on 1–3 issues per run; you may scan many more to find good candidates. Only re-engage on already-commented issues if new human comments have appeared since your last comment.
140+
2. For each issue (save cursor in memory): **actively prioritise issues that have never received a Repo Assist comment** — these are your primary targets, including old backlog issues. Read the issue comments and check your memory's `comments_made` fields to help determine priority issues. Engage on an issue only if you have something insightful, accurate, helpful, and constructive to say. Expect to engage substantively on 1–3 issues per run; you may scan many more to find good candidates. Expect to eventually engage on most issues - only very rarely choose not to engage, as your engagement is usually helpful. Only re-engage on already-commented issues if new human comments engaging in conversation with you have appeared since your last comment.
141141
3. Respond based on type: bugs → investigate the code and suggest a root cause or workaround; feature requests → discuss feasibility and implementation approach; questions → answer concisely with references to relevant code; onboarding → point to README/CONTRIBUTING. Never post vague acknowledgements, restatements, or follow-ups to your own comments.
142142
4. Begin every comment with: `🤖 *This is an automated response from Repo Assist.*`
143143
5. Update memory with comments made and the new cursor position. **Remove issue numbers from the "uncommented issues" note when you comment on them.**
144144

145-
**Important**: If your memory notes that certain issues (e.g., #384, #336, #323) "have labels but no Repo Assist comments", treat this as a backlog you must work through — do not defer indefinitely.
145+
**Important**: If issues have labels but no Repo Assist comments, treat this as a backlog you must work through — do not defer indefinitely.
146146

147147
### Task 2: Fix Issues via Pull Requests
148148

@@ -294,4 +294,4 @@ Maintain a single open issue titled `[Repo Assist] Monthly Activity {YYYY}-{MM}`
294294
- **Anti-spam**: no repeated or follow-up comments to yourself in a single run; re-engage only when new human comments have appeared.
295295
- **Systematic**: use the backlog cursor to process oldest issues first over successive runs. Do not stop early.
296296
- **Quality over quantity**: noise erodes trust. Do nothing rather than add low-value output.
297-
- **Bias toward action**: While avoiding spam, actively seek ways to contribute value. If you're about to conclude "no action needed", first verify: (a) you've checked the full open issue list, not just recent activity, (b) there are no uncommented issues in your memory backlog, (c) no issues are fixable or investigatable, (d) all labeling is current. A "no action" run should be genuinely exceptional.
297+
- **Bias toward action**: While avoiding spam, actively seek ways to contribute value. If you're about to conclude "no action needed", first verify: (a) you've checked the full open issue list, not just recent activity, (b) check there are no uncommented issues where you haven't engaged but should, (c) check there are no issues that are fixable or investigatable, (d) check all labeling is current, (e) check there are no useful engineering improvements you could perform, (f) check there is no testing to improve, (g) check there are no dependency updates to make, (h) check there are no code simplifications to make, (i) check there are no documentation improvements to make, (j) check there are no CI performance improvements to make. A "no action" run should be genuinely exceptional except in a near-perfect repository with no recent changes.

AGENTS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,3 +69,5 @@ Update `RELEASE_NOTES.md` at the top of the file for any user-facing changes. Fo
6969

7070
- Description of change by @author in #PR
7171
```
72+
73+
You should bump the version number in `RELEASE_NOTES.md` and `Directory.Build.props` for the next release - choose a new version number following semantic versioning guidelines. Assume that any listed versions have already been released.

CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,9 @@ between _runtime_ and _design-time_ components, so you'll find at least two file
8787

8888
### Debugging
8989

90-
To debug the type generation, the best way is to change `FSharp.Data.DesignTime` project to a Console application,
91-
rename `Test.fsx` to `Test.fs` and hit the Run command in the IDE, setting the breakpoints where you need them.
92-
This will invoke all the type providers manually without locking the files in Visual Studio / Xamarin Studio.
93-
You'll also see in the console output the complete dump of the generated types and expressions.
90+
To debug the type generation, the best way is to change `FSharp.Data.DesignTime` project to a Console application and hit the Run command in the IDE, setting the breakpoints where you need them.
91+
This will invoke all the type providers manually without locking the files in Visual Studio / Xamarin Studio.
92+
You'll also see in the console output the complete dump of the generated types and expressions.
9493
This is also the process used for the signature tests.
9594

9695
## Documentation

RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 9.0.0 - Feb 26 2026
44

55
- Change HTTP response default encoding from ISO-8859-1 to UTF-8 to match `System.Net.Http.HttpClient` behaviour (closes #1251)
6+
- Make `Http.AppendQueryToUrl` public (closes #1325)
67
- Add `PreferOptionals` parameter to `JsonProvider` and `XmlProvider` (defaults to `true` to match existing behavior; set to `false` to use empty string or `NaN` for missing values, like the CsvProvider default) (closes #649)
78

89
## 8.0.0 - Feb 25 2026

src/FSharp.Data.DesignTime/FSharp.Data.DesignTime.fsproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
<Compile Include="Html/HtmlGenerator.fs" />
3434
<Compile Include="Html/HtmlProvider.fs" />
3535
<Compile Include="../AssemblyInfo.DesignTime.fs" />
36-
<None Include="../Test.fsx" />
3736
<None Include="paket.references" />
3837
</ItemGroup>
3938
<ItemGroup>

src/FSharp.Data.Http/Http.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2004,7 +2004,7 @@ type Http private () =
20042004
(WebUtility.UrlEncode query).Replace("+", "%20")
20052005

20062006
/// Appends the query parameters to the url, taking care of proper escaping
2007-
static member internal AppendQueryToUrl(url: string, query) =
2007+
static member AppendQueryToUrl(url: string, query) =
20082008
match query with
20092009
| [] -> url
20102010
| query ->

src/SetupTesting.fsx

Lines changed: 0 additions & 53 deletions
This file was deleted.

src/Test.fsx

Lines changed: 0 additions & 129 deletions
This file was deleted.

0 commit comments

Comments
 (0)