Commit d4c5516
test+eng: 37 StructuralInference unit tests; CI reads SDK version from global.json
Task 9 — Testing Improvements:
Add tests/FSharp.Data.Core.Tests/StructuralInference.fs with 37 unit
tests covering the core type-inference module (StructuralInference.fs,
the largest source file at 777 lines) which previously had no dedicated
test file. Tests cover:
- typeTag (all InferedType cases incl. NET6+ DateOnly/TimeOnly)
- subtypeInfered: Top/Null merging, numeric widening hierarchy
(Bit0+Bit1→Bit, int+int64→int64, int+float→float, decimal+float→float,
Bit0+bool→bool), incompatible types → Heterogeneous, optionality
- subtypeInfered with Records: field union, different names → Heterogeneous
- inferCollectionType: single type, mixed numeric widening, multiplicity
- getInferedTypeFromString: empty→Null, Bit/bool/int/int64/decimal/string/
Guid inference, NoInference mode
- InferenceMode'.FromPublicApi: all enum values
- supportsUnitsOfMeasure: numeric vs non-numeric types
All 2957 tests pass (was 2920 before; +37 new).
Task 4 — Engineering Investments:
Replace hardcoded dotnet-version: 10.0.201 in pull-requests.yml (×3)
and push-master.yml (×1) with dotnet-version-file: global.json.
The SDK version is now a single source of truth in global.json
(which already has rollForward: latestMinor). Also update step
names from 'Setup .NET 10' to 'Setup .NET' so they stay accurate
after future SDK bumps.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 3884515 commit d4c5516
4 files changed
Lines changed: 363 additions & 8 deletions
File tree
- .github/workflows
- tests/FSharp.Data.Core.Tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| |||
0 commit comments