Skip to content

Commit f1cc5a7

Browse files
authored
Merge branch 'main' into test-coverage-improvement-json-html-20250831
2 parents 52e2e92 + a929c68 commit f1cc5a7

7 files changed

Lines changed: 52 additions & 17 deletions

File tree

.github/workflows/ci-doctor.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/daily-perf-improver.lock.yml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/daily-perf-improver.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,18 @@ tools:
3939
WebSearch:
4040
# Configure bash build commands here, or in .github/workflows/agentics/daily-perf-improver.config.md
4141
#Bash: [":*"]
42-
Bash: ["gh pr create:*", "git commit:*", "git push:*", "git checkout:*", "git branch:*", "git add:*", "gh auth status", "gh repo view", "gh issue comment:*"]
42+
Bash:
43+
- "gh pr create:*"
44+
- "git commit:*"
45+
- "git push:*"
46+
- "git checkout:*"
47+
- "git branch:*"
48+
- "git add:*"
49+
- "gh auth status"
50+
- "gh repo view"
51+
- "gh issue comment:*"
52+
- "gh issue list:*"
53+
- "gh pr list:*"
4354

4455
steps:
4556
- name: Checkout repository
@@ -69,7 +80,7 @@ Your name is ${{ github.workflow }}. Your job is to act as an agentic coder for
6980

7081
1. Performance research (if not done before).
7182

72-
1a. Check if an open issue with title "${{ github.workflow }}: Research and Plan" exists. If it does, read the issue and its comments, paying particular attention to comments from repository maintainers, then continue to step 2. If not, follow the steps below to create it:
83+
1a. Check if an open issue with title "${{ github.workflow }}: Research and Plan" exists using `gh issue list --search 'is:open in:title \"Research and Plan\"'`. If it does, read the issue and its comments, paying particular attention to comments from repository maintainers, then continue to step 2. If the issue doesn't exist, follow the steps below to create it:
7384

7485
1b. Do some deep research into performance matters in this repo.
7586
- How is performance testing is done in the repo?

.github/workflows/daily-test-improver.lock.yml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/daily-test-improver.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,18 @@ tools:
4040
WebSearch:
4141
# Configure bash build commands here, or in .github/workflows/agentics/daily-test-improver.config.md
4242
#Bash: [":*"]
43-
Bash: ["gh pr create:*", "git commit:*", "git push:*", "git checkout:*", "git branch:*", "git add:*", "gh auth status", "gh repo view", "gh issue comment:*"]
43+
Bash:
44+
- "gh pr create:*"
45+
- "git commit:*"
46+
- "git push:*"
47+
- "git checkout:*"
48+
- "git branch:*"
49+
- "git add:*"
50+
- "gh auth status"
51+
- "gh repo view"
52+
- "gh issue comment:*"
53+
- "gh issue list:*"
54+
- "gh pr list:*"
4455

4556
steps:
4657
- name: Checkout repository
@@ -70,7 +81,7 @@ Your name is ${{ github.workflow }}. Your job is to act as an agentic coder for
7081

7182
1. Testing research (if not done before).
7283

73-
1a. Check if an open issue with title "${{ github.workflow }}: Research and Plan" exists. If it does, read the issue and its comments, paying particular attention to comments from repository maintainers, then continue to step 2. If not, follow the steps below to create it:
84+
1a. Check if an open issue with title "${{ github.workflow }}: Research and Plan" exists using `gh issue list --search 'is:open in:title \"Research and Plan\"'`. If it does, read the issue and its comments, paying particular attention to comments from repository maintainers, then continue to step 2. If the issue doesn't exist, follow the steps below to create it:
7485

7586
1b. Research the repository to understand its purpose, functionality, and technology stack. Look at the README.md, project documentation, code files, and any other relevant information.
7687

.github/workflows/pr-fix.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/FSharp.Data.Benchmarks/JsonBenchmarks.fs

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,27 @@ type JsonConversionBenchmarks() =
6969

7070
[<Benchmark>]
7171
member this.AccessProperties() =
72-
sampleJson.Properties()
73-
|> Array.head
74-
|> fun (_, value) -> value
72+
match sampleJson with
73+
| JsonValue.Array elements when elements.Length > 0 ->
74+
// Get properties of the first issue in the GitHub issues array
75+
elements.[0].Properties()
76+
|> Array.head
77+
|> fun (_, value) -> value
78+
| JsonValue.Record _ ->
79+
// Fallback for record-type JSON
80+
sampleJson.Properties()
81+
|> Array.head
82+
|> fun (_, value) -> value
83+
| _ -> JsonValue.Null
7584

7685
[<Benchmark>]
7786
member this.GetArrayElements() =
7887
match sampleJson with
88+
| JsonValue.Array elements ->
89+
// GitHub.json is an array of issues, return the array elements
90+
elements
7991
| JsonValue.Record props ->
92+
// Fallback: look for an "items" property
8093
match Array.tryFind (fun (k, _) -> k = "items") props with
8194
| Some (_, JsonValue.Array elements) -> elements
8295
| _ -> [||]

0 commit comments

Comments
 (0)