Skip to content

Avoid ReadToEnd and use XDocument taking reader instead#1527

Merged
dsyme merged 2 commits intofsprojects:mainfrom
Thorium:pass-reader
Aug 30, 2025
Merged

Avoid ReadToEnd and use XDocument taking reader instead#1527
dsyme merged 2 commits intofsprojects:mainfrom
Thorium:pass-reader

Conversation

@Thorium
Copy link
Copy Markdown
Member

@Thorium Thorium commented Mar 25, 2025

Avoid ReadToEnd and use XDocument taking reader instead.

Possible fix for #1501

@Thorium
Copy link
Copy Markdown
Member Author

Thorium commented Mar 25, 2025

Ubuntu CI failed for "CsvRuntime.fs needs formatting". However, this PR only touches XmlRuntime.fs not CsvRuntime.fs.
Locally running Fantomas or dotnet run --project build/build.fsproj -- -t Format is not changing any files.

@dsyme dsyme merged commit 38149d9 into fsprojects:main Aug 30, 2025
2 checks passed
dsyme pushed a commit that referenced this pull request Feb 21, 2026
Consolidate all changes since 6.5.0 into RELEASE_NOTES.md
and mark 6.6.0 as released, opening 6.7.0 unreleased section.

Changes included in 6.6.0:
- Security fix: XXE vulnerability in XML parsing (#1596)
- Bug fix: XML provider uses XDocument reader instead of ReadToEnd (#1527)
- Performance: HTML parser CharList uses StringBuilder (~43% faster) (#1550)
- Performance: JSON string serialization bulk writes (#1562)
- Performance: RemoveAdorners fast-path for adorner-free strings (#1540)
- Feature: HTML HIDE_REPRESENTATION compile-time opt-in (#1499)
- Documentation: Fix links (#1597)
- Tests: Expanded coverage across all modules

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants