Skip to content

Daily Perf Improver: Fix broken benchmarks for reliable performance testing #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 3 commits into from
Aug 31, 2025
Merged

Daily Perf Improver: Fix broken benchmarks for reliable performance testing #1569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e09b15e
Fix broken benchmarks for reliable performance testing
claude Aug 31, 2025
6d307d5
Merge branch 'main' into fix-benchmark-issues
dsyme Aug 31, 2025
715d13a
Fix failing JsonProvider tests by restoring original TwitterSample.js…
claude Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tests/FSharp.Data.Benchmarks/JsonBenchmarks.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,27 @@ type JsonConversionBenchmarks() =

[<Benchmark>]
member this.AccessProperties() =
sampleJson.Properties()
|> Array.head
|> fun (_, value) -> value
match sampleJson with
| JsonValue.Array elements when elements.Length > 0 ->
// Get properties of the first issue in the GitHub issues array
elements.[0].Properties()
|> Array.head
|> fun (_, value) -> value
| JsonValue.Record _ ->
// Fallback for record-type JSON
sampleJson.Properties()
|> Array.head
|> fun (_, value) -> value
| _ -> JsonValue.Null

[<Benchmark>]
member this.GetArrayElements() =
match sampleJson with
| JsonValue.Array elements ->
// GitHub.json is an array of issues, return the array elements
elements
| JsonValue.Record props ->
// Fallback: look for an "items" property
match Array.tryFind (fun (k, _) -> k = "items") props with
| Some (_, JsonValue.Array elements) -> elements
| _ -> [||]
Expand Down
Loading