Skip to content

[Repo Assist] fix: dispose SHA1 instance in Caching.hashString; use SHA1.HashData on .NET 5+ #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 2 commits into from
Apr 17, 2026
Merged

[Repo Assist] fix: dispose SHA1 instance in Caching.hashString; use SHA1.HashData on .NET 5+ #1745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7575c2
fix: dispose SHA1 instance in Caching.hashString; use SHA1.HashData o…
github-actions[bot] Apr 16, 2026
2dd182c
ci: trigger checks
github-actions[bot] Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/FSharp.Data.Runtime.Utilities/Caching.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,15 @@ let createInMemoryCache (expiration: TimeSpan) =
/// Get hash code of a string - used to determine cache file
let private hashString (plainText: string) =
let plainTextBytes = Encoding.UTF8.GetBytes(plainText)
let hashBytes = SHA1.Create().ComputeHash(plainTextBytes)

let hashBytes =
#if NET5_0_OR_GREATER
SHA1.HashData(plainTextBytes)
#else
use sha1 = SHA1.Create()
sha1.ComputeHash(plainTextBytes)
#endif

let s = Convert.ToBase64String(hashBytes)
s.Replace("ab", "abab").Replace("\\", "ab")

Expand Down
Loading