Conversation
…m global.json Task 9 — Testing Improvements: Add tests/FSharp.Data.Core.Tests/StructuralInference.fs with 37 unit tests covering the core type-inference module (StructuralInference.fs, the largest source file at 777 lines) which previously had no dedicated test file. Tests cover: - typeTag (all InferedType cases incl. NET6+ DateOnly/TimeOnly) - subtypeInfered: Top/Null merging, numeric widening hierarchy (Bit0+Bit1→Bit, int+int64→int64, int+float→float, decimal+float→float, Bit0+bool→bool), incompatible types → Heterogeneous, optionality - subtypeInfered with Records: field union, different names → Heterogeneous - inferCollectionType: single type, mixed numeric widening, multiplicity - getInferedTypeFromString: empty→Null, Bit/bool/int/int64/decimal/string/ Guid inference, NoInference mode - InferenceMode'.FromPublicApi: all enum values - supportsUnitsOfMeasure: numeric vs non-numeric types All 2957 tests pass (was 2920 before; +37 new). Task 4 — Engineering Investments: Replace hardcoded dotnet-version: 10.0.201 in pull-requests.yml (×3) and push-master.yml (×1) with dotnet-version-file: global.json. The SDK version is now a single source of truth in global.json (which already has rollForward: latestMinor). Also update step names from 'Setup .NET 10' to 'Setup .NET' so they stay accurate after future SDK bumps. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…4-17-cd136a8845dc218d
dsyme
deleted the
repo-assist/test-structural-inference-2026-04-17-cd136a8845dc218d
branch
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 9 — Testing Improvements:
Add tests/FSharp.Data.Core.Tests/StructuralInference.fs with 37 unit
tests covering the core type-inference module (StructuralInference.fs,
the largest source file at 777 lines) which previously had no dedicated
test file. Tests cover:
(Bit0+Bit1→Bit, int+int64→int64, int+float→float, decimal+float→float,
Bit0+bool→bool), incompatible types → Heterogeneous, optionality
Guid inference, NoInference mode
All 2957 tests pass (was 2920 before; +37 new).
Task 4 — Engineering Investments:
Replace hardcoded dotnet-version: 10.0.201 in pull-requests.yml (×3)
and push-master.yml (×1) with dotnet-version-file: global.json.
The SDK version is now a single source of truth in global.json
(which already has rollForward: latestMinor). Also update step
names from 'Setup .NET 10' to 'Setup .NET' so they stay accurate
after future SDK bumps.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com