Commit 2d8a1b8
[Repo Assist] fix: Markdown.ToMd preserves DirectLink and DirectImage titles (#1150)
* fix: Markdown.ToMd preserves DirectLink and DirectImage titles
When serialising a document with ToMd, link and image titles were
silently dropped. A Markdown fragment such as
[text](url "My Title")
would round-trip as
[text](url)
because the `DirectLink` / `DirectImage` formatSpan cases matched the
title field with a wildcard.
Fix: give DirectLink and DirectImage their own branches so the optional
title can be appended in CommonMark form ( \"title\").
Three new round-trip tests cover:
- DirectLink with title
- DirectLink without title (unchanged behaviour)
- DirectImage with title
All 284 Markdown tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* ci: trigger checks
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Don Syme <dsyme@users.noreply.github.com>1 parent 5c5f73b commit 2d8a1b8
3 files changed
Lines changed: 39 additions & 2 deletions
File tree
- src/FSharp.Formatting.Markdown
- tests/FSharp.Markdown.Tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
109 | 117 | | |
110 | | - | |
111 | 118 | | |
112 | 119 | | |
113 | 120 | | |
114 | 121 | | |
115 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
116 | 130 | | |
117 | 131 | | |
118 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1269 | 1269 | | |
1270 | 1270 | | |
1271 | 1271 | | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
1272 | 1286 | | |
1273 | 1287 | | |
1274 | 1288 | | |
1275 | 1289 | | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
1276 | 1298 | | |
1277 | 1299 | | |
1278 | 1300 | | |
| |||
0 commit comments