Skip to content

Commit 6f78060

Browse files
authored
Merge pull request #1174 from fsprojects/repo-assist/improve-fcs-pin-seq-cast-2026-04-18-7bf530223a32aad3
[Repo Assist] eng: fix stale FCS VersionOverride; replace Enumerable.Cast with Seq.cast
2 parents 01844d6 + 9a66ada commit 6f78060

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

RELEASE_NOTES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* Replace deprecated `System.Net.WebClient` with `System.Net.Http.HttpClient` in the image downloader used by `--saveimages`. Removes the `#nowarn "44"` suppression.
88
* Bump `Newtonsoft.Json` transitive-dependency pin from 13.0.3 to 13.0.4.
99
* Bump `System.Memory` transitive-dependency pin from 4.5.5 to 4.6.3.0
10+
* Remove stale `VersionOverride="43.12.201"` on the `FSharp.Compiler.Service` reference in `FSharp.Formatting.Markdown.fsproj`; the package now uses the central pin (`43.12.202`) from `Directory.Packages.props`, eliminating the NU1605 build warning.
11+
* Replace `Enumerable.Cast<XAttribute>` (LINQ) with `Seq.cast<XAttribute>` (idiomatic F#) in `MarkdownUtils.fs`, removing the `open System.Linq` import.
1012

1113
### Fixed
1214
* Fix `Markdown.ToMd` silently dropping YAML frontmatter when serialising a parsed `MarkdownDocument` back to Markdown text. Frontmatter is now preserved with its `---` delimiters.

src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<ProjectReference Include="..\FSharp.Formatting.Common\FSharp.Formatting.Common.fsproj" />
2727
</ItemGroup>
2828
<ItemGroup>
29-
<PackageReference Include="FSharp.Compiler.Service" VersionOverride="43.12.201" />
29+
<PackageReference Include="FSharp.Compiler.Service" />
3030
<PackageReference Include="FSharp.Core" />
3131
</ItemGroup>
3232
</Project>

src/FSharp.Formatting.Markdown/MarkdownUtils.fs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ namespace rec FSharp.Formatting.Markdown
66

77
open System
88
open System.Collections.Generic
9-
open System.Linq
109
open System.Xml.Linq
1110
open FSharp.Formatting.Templating
1211

@@ -423,7 +422,7 @@ module internal MarkdownUtils =
423422
let attributes =
424423
match System.Xml.XPath.Extensions.XPathEvaluate(element, "//*/@*[contains(., '.md')]") with
425424
| :? System.Collections.IEnumerable as enumerable ->
426-
enumerable |> Enumerable.Cast<XAttribute> |> Seq.toArray
425+
enumerable |> Seq.cast<XAttribute> |> Seq.toArray
427426
| _ -> Array.empty
428427

429428
if Array.isEmpty attributes then

0 commit comments

Comments
 (0)