Merge branch 'main' into repo-assist/feature-811-fsdocs-convert-2cf2c2973fcbd211

Author: dsyme

.github/workflows/repo-assist.lock.yml

@@ -71,7 +71,7 @@ tools:
   bash: true
   repo-memory: true
 
-source: githubnext/agentics/workflows/repo-assist.md@f2c5cf1e4af58e09a93ba0703c6bf084711b265f
+source: githubnext/agentics/workflows/repo-assist.md@afb00b92a9514fee9a14c583f059a03d05738f70
 ---
 
 # Repo Assist
@@ -109,23 +109,35 @@ Use persistent repo memory to track:
 
 Read memory at the **start** of every run; update it at the **end**.
 
-**Important**: Memory may not be 100% accurate. Issues may have been created, closed, or commented on; PRs may have been created, merged, commented on, or closed since the last run. Always verify memory against current repository state  -  reviewing recent activity since your last run is wise before acting on stale assumptions.
+**Important**: Memory may not be 100% accurate. Issues may have been created, closed, or commented on; PRs may have been created, merged, commented on, or closed since the last run. Always verify memory against current repository state — reviewing recent activity since your last run is wise before acting on stale assumptions.
+
+**Memory backlog tracking**: Your memory may contain notes about issues or PRs that still need attention (e.g., "issues #384, #336 have labels but no comments"). These are **action items for you**, not just informational notes. Each run, check your memory's `notes` field and other tracking fields for any explicitly flagged backlog work, and prioritise acting on it.
 
 ## Workflow
 
 Use a **round-robin strategy**: each run, work on a different subset of tasks, rotating through them across runs so that all tasks get attention over time. Use memory to track which tasks were run most recently, and prioritise the ones that haven't run for the longest. Aim to do 2–4 tasks per run (plus the mandatory Task 11).
 
 **Repeat-run mode**: When invoked via `gh aw run repo-assist --repeat`, runs occur every 5–10 minutes. Even in this mode, **actively look for useful work to do** on every run. Do not skip a run just because the last one was recent or because open PRs are awaiting CI — there is always a task to advance: label issues, scan the backlog, study the codebase, prepare a fix, push an update, or work on Task 10. Treat a "nothing to do" conclusion as a sign you haven't looked hard enough, unless there really is, like, literally nothing to do. And be careful not to do duplicate work across runs — check memory to see if you've already tried a fix or commented on an issue before doing it again.
 
+**Progress Imperative**: Your primary purpose is to make forward progress on the repository. A "no action taken" outcome should be rare and only occur when:
+- Every open issue has either been fixed, is being actively worked on, or has already received a substantive Repo Assist comment AND no new human activity has occurred
+- Every open PR has been reviewed or commented on appropriately
+- All labeling is complete
+- There are genuinely no improvements, fixes, or triage actions possible
+
+If your memory notes issues that "have labels but no Repo Assist comments" or similar backlog items, **you must act on them** — don't just note them for future runs. Scan the full issue list, not just recent activity. The absence of new issues since your last run does not mean there's nothing to do — there may be older issues awaiting triage, comment, or fix attempts.
+
 Always do Task 11 (Update Monthly Activity Summary Issue) every run. In all comments and PR descriptions, identify yourself as "Repo Assist".
 
 ### Task 1: Triage and Comment on Open Issues
 
 1. List open issues sorted by creation date ascending (oldest first). Resume from your memory's backlog cursor; reset when you reach the end.
-2. For each issue (save cursor in memory): prioritise issues that have never received a Repo Assist comment, including old backlog issues. Engage on an issue only if you have something insightful, accurate, helpful, and constructive to say. Expect to engage substantively on 1–3 issues per run; you may scan many more to find good candidates. Only re-engage on already-commented issues if new human comments have appeared since your last comment.
-3. Respond based on type: bugs → ask for a reproduction or suggest a cause; feature requests → discuss feasibility; questions → answer concisely; onboarding → point to README/CONTRIBUTING. Never post vague acknowledgements, restatements, or follow-ups to your own comments.
+2. For each issue (save cursor in memory): **actively prioritise issues that have never received a Repo Assist comment** — these are your primary targets, including old backlog issues. Read the issue comments and check your memory's `comments_made` fields to help determine priority issues. Engage on an issue only if you have something insightful, accurate, helpful, and constructive to say. Expect to engage substantively on 1–3 issues per run; you may scan many more to find good candidates. Expect to eventually engage on most issues - only very rarely choose not to engage, as your engagement is usually helpful. Only re-engage on already-commented issues if new human comments engaging in conversation with you have appeared since your last comment.
+3. Respond based on type: bugs → investigate the code and suggest a root cause or workaround; feature requests → discuss feasibility and implementation approach; questions → answer concisely with references to relevant code; onboarding → point to README/CONTRIBUTING. Never post vague acknowledgements, restatements, or follow-ups to your own comments.
 4. Begin every comment with: `🤖 *This is an automated response from Repo Assist.*`
-5. Update memory with comments made and the new cursor position.
+5. Update memory with comments made and the new cursor position. **Remove issue numbers from the "uncommented issues" note when you comment on them.**
+
+**Important**: If issues have labels but no Repo Assist comments, treat this as a backlog you must work through — do not defer indefinitely.
 
 ### Task 2: Fix Issues via Pull Requests
 
@@ -263,7 +275,7 @@ Maintain a single open issue titled `[Repo Assist] Monthly Activity {YYYY}-{MM}`
    - PRs that should be closed (stale, superseded, etc.)
    - Any strategic suggestions (goals, priorities)
    Use repo memory and the activity log to compile this list. Include direct links for every item. Keep entries to one line each.
-5. Do not update the activity issue if nothing was done in the current run.
+5. Do not update the activity issue if nothing was done in the current run. However, if you conclude "nothing to do", first verify this by checking: (a) Are there any open issues without a Repo Assist comment? (b) Are there issues in your memory flagged for attention? (c) Are there any bugs that could be investigated or fixed? If any of these are true, go back and do that work instead of concluding with no action.
 
 ## Guidelines
 
@@ -277,3 +289,4 @@ Maintain a single open issue titled `[Repo Assist] Monthly Activity {YYYY}-{MM}`
 - **Anti-spam**: no repeated or follow-up comments to yourself in a single run; re-engage only when new human comments have appeared.
 - **Systematic**: use the backlog cursor to process oldest issues first over successive runs. Do not stop early.
 - **Quality over quantity**: noise erodes trust. Do nothing rather than add low-value output.
+- **Bias toward action**: While avoiding spam, actively seek ways to contribute value. If you're about to conclude "no action needed", first verify: (a) you've checked the full open issue list, not just recent activity, (b) check there are no uncommented issues where you haven't engaged but should, (c) check there are no issues that are fixable or investigatable, (d) check all labeling is current, (e) check there are no useful engineering improvements you could perform, (f) check there is no testing to improve, (g) check there are no dependency updates to make, (h) check there are no code simplifications to make, (i) check there are no documentation improvements to make, (j) check there are no CI performance improvements to make. A "no action" run should be genuinely exceptional except in a near-perfect repository with no recent changes.

.github/workflows/repo-assist.md

@@ -7,18 +7,23 @@
 * `fsdocs convert` now accepts the input file as a positional argument (e.g. `fsdocs convert notebook.ipynb -o notebook.html`). [#1019](https://github.com/fsprojects/FSharp.Formatting/pull/1019)
 * `fsdocs convert` infers the output format from the output file extension when `--outputformat` is not specified (e.g. `-o out.md` implies `--outputformat markdown`). [#1019](https://github.com/fsprojects/FSharp.Formatting/pull/1019)
 * `fsdocs convert` now accepts `-o` as a shorthand for `--output`. [#1019](https://github.com/fsprojects/FSharp.Formatting/pull/1019)
+* Add "Copy" button to all code blocks in generated documentation, making it easy to copy code samples to the clipboard. [#72](https://github.com/fsprojects/FSharp.Formatting/issues/72)
 * Add `<FsDocsAllowExecutableProject>true</FsDocsAllowExecutableProject>` project file setting to include executable projects (OutputType=Exe/WinExe) in API documentation generation. [#918](https://github.com/fsprojects/FSharp.Formatting/issues/918)
 * Add `{{fsdocs-logo-alt}}` substitution (configurable via `<FsDocsLogoAlt>` MSBuild property, defaults to `Logo`) for accessible alt text on the header logo image. [#626](https://github.com/fsprojects/FSharp.Formatting/issues/626)
 
 ### Fixed
+* Fix doc generation failure for members with 5D/6D+ array parameters by correctly formatting array type signatures in XML doc format (e.g. `System.Double[0:,0:,0:,0:,0:]` for a 5D array). [#702](https://github.com/fsprojects/FSharp.Formatting/issues/702)
 * Fix `_menu_template.html` and `_menu-item_template.html` being copied to the output directory. [#803](https://github.com/fsprojects/FSharp.Formatting/issues/803)
 * Fix `ApiDocMember.Details.ReturnInfo.ReturnType` returning `None` for properties that have both a getter and a setter. [#734](https://github.com/fsprojects/FSharp.Formatting/issues/734)
 * Improve error message when a named code snippet is not found (e.g. `(*** include:name ***)` with undefined name now reports the missing name clearly). [#982](https://github.com/fsprojects/FSharp.Formatting/pull/982)
 * HTML-encode XML doc text nodes and unresolved `<see cref>` values to prevent HTML injection and fix broken output when docs contain characters like `<`, `>`, or backticks in generic type notation. [#748](https://github.com/fsprojects/FSharp.Formatting/issues/748)
 * Add uppercase output kind extension (e.g. `HTML`, `IPYNB`) to `ConditionalDefines` so that `#if HTML` and `(*** condition: HTML ***)` work alongside their lowercase variants. [#693](https://github.com/fsprojects/FSharp.Formatting/issues/693)
 * Strip `#if SYMBOL` / `#endif // SYMBOL` marker lines from `LiterateCode` source before syntax-highlighting so they do not appear in formatted output. [#693](https://github.com/fsprojects/FSharp.Formatting/issues/693)
+* Members and functions annotated with `CompilerMessageAttribute(IsHidden=true)` are now automatically excluded from API docs, matching the behaviour of `[omit]` / `<exclude/>`. [#144](https://github.com/fsprojects/FSharp.Formatting/issues/144)
 * Fix incorrect column ranges for inline spans (links, images, inline code) in the Markdown parser — spans and subsequent literals now report correct `StartColumn`/`EndColumn` values. [#744](https://github.com/fsprojects/FSharp.Formatting/issues/744)
 * Normalize `--projects` paths to absolute paths before passing to the project cracker, fixing failures when relative paths are supplied. [#793](https://github.com/fsprojects/FSharp.Formatting/issues/793)
+* Fix incorrect paragraph indentation for loose list items: a paragraph indented at the outer list item's continuation level is now correctly treated as a sibling of surrounding sublists rather than being absorbed into the first sublist item's body. [#347](https://github.com/fsprojects/FSharp.Formatting/issues/347)
+* Improve CommonMark compliance for ATX headings: reject `#` not followed by a space (e.g. `#NoSpace` is now a paragraph), reject more than 6 `#` characters as a heading, support 0–3 leading spaces before the opening `#` sequence, and fix empty content when the entire header body is a closing `###` sequence. [#191](https://github.com/fsprojects/FSharp.Formatting/issues/191)
 
 ### Changed
 * Update FCS to 43.10.100. [#935](https://github.com/fsprojects/FSharp.Formatting/pull/966)

RELEASE_NOTES.md

@@ -97,6 +97,7 @@
 <script type="module" src="{{root}}content/fsdocs-details-toggle.js"></script>
 <script type="module" src="{{root}}content/fsdocs-theme.js"></script>
 <script type="module" src="{{root}}content/fsdocs-search.js"></script>
+<script type="module" src="{{root}}content/fsdocs-copy-button.js"></script>
 {{fsdocs-body-extra}}
 </body>
 </html>

docs/_template.html

@@ -0,0 +1,75 @@
+// Adds a "Copy" button to every code block so readers can easily copy snippets.
+function createCopyButton() {
+    const button = document.createElement('button')
+    button.className = 'copy-code-button'
+    button.setAttribute('aria-label', 'Copy code to clipboard')
+    button.textContent = 'Copy'
+    return button
+}
+
+function attachCopyHandler(button, getText) {
+    button.addEventListener('click', function () {
+        const text = getText()
+        if (navigator.clipboard && navigator.clipboard.writeText) {
+            navigator.clipboard.writeText(text).then(
+                function () {
+                    button.textContent = 'Copied!'
+                    setTimeout(function () {
+                        button.textContent = 'Copy'
+                    }, 2000)
+                },
+                function () {
+                    button.textContent = 'Failed'
+                    setTimeout(function () {
+                        button.textContent = 'Copy'
+                    }, 2000)
+                }
+            )
+        } else {
+            // Fallback for non-HTTPS environments
+            const el = document.createElement('textarea')
+            el.value = text
+            document.body.appendChild(el)
+            el.select()
+            document.execCommand('copy')
+            document.body.removeChild(el)
+            button.textContent = 'Copied!'
+            setTimeout(function () {
+                button.textContent = 'Copy'
+            }, 2000)
+        }
+    })
+}
+
+document.addEventListener('DOMContentLoaded', function () {
+    // table.pre blocks (F# highlighted code, sometimes with line numbers)
+    document.querySelectorAll('table.pre').forEach(function (table) {
+        const wrapper = document.createElement('div')
+        wrapper.className = 'code-block-wrapper'
+        table.parentNode.insertBefore(wrapper, table)
+        wrapper.appendChild(table)
+
+        const button = createCopyButton()
+        wrapper.appendChild(button)
+
+        const snippet = table.querySelector('.snippet pre')
+        attachCopyHandler(button, function () {
+            return (snippet || table).innerText
+        })
+    })
+
+    // Standard pre > code blocks (Markdown fenced code, standalone fssnip, etc.)
+    // Skip those already handled inside table.pre above.
+    document.querySelectorAll('pre > code').forEach(function (code) {
+        if (code.closest('table.pre')) return
+        const pre = code.parentElement
+        pre.classList.add('has-copy-button')
+
+        const button = createCopyButton()
+        pre.appendChild(button)
+
+        attachCopyHandler(button, function () {
+            return code.innerText
+        })
+    })
+})

docs/content/fsdocs-copy-button.js

@@ -731,7 +731,7 @@ h1 code, h2 code, h3 code, h4 code, h5 code, h6 code {
     font-size: inherit;
 }
 
-table.pre, #content > pre.fssnip {
+table.pre, #content > pre.fssnip, .code-block-wrapper > table.pre {
     border: 1px solid var(--code-fence-border-color);
 }
 
@@ -740,6 +740,47 @@ table.pre, pre.fssnip.highlighted {
     padding: var(--spacing-200);
 }
 
+/* Copy code button */
+.code-block-wrapper {
+    position: relative;
+    display: block;
+    margin: var(--spacing-300) 0;
+}
+
+.code-block-wrapper > table.pre {
+    margin: 0;
+}
+
+pre.has-copy-button {
+    position: relative;
+}
+
+.copy-code-button {
+    position: absolute;
+    top: var(--spacing-100);
+    right: var(--spacing-100);
+    padding: var(--spacing-50) var(--spacing-100);
+    background-color: var(--header-background);
+    border: 1px solid var(--header-border);
+    border-radius: var(--radius);
+    color: var(--text-color);
+    cursor: pointer;
+    font-family: var(--system-font);
+    font-size: var(--font-50);
+    opacity: 0;
+    transition: opacity 0.2s ease-in-out;
+    z-index: 10;
+
+    &:hover {
+        background-color: var(--menu-item-hover-background);
+    }
+}
+
+pre.has-copy-button:hover .copy-code-button,
+.code-block-wrapper:hover .copy-code-button {
+    opacity: 1;
+}
+
 table.pre .snippet pre.fssnip {
     padding: 0;
     margin: 0;

docs/content/fsdocs-default.css

@@ -45,12 +45,16 @@ function showTip(evt, name, unique, owner) {
 }
 
 function Clipboard_CopyTo(value) {
-    const tempInput = document.createElement("input");
-    tempInput.value = value;
-    document.body.appendChild(tempInput);
-    tempInput.select();
-    document.execCommand("copy");
-    document.body.removeChild(tempInput);
+    if (navigator.clipboard) {
+        navigator.clipboard.writeText(value);
+    } else {
+        const tempInput = document.createElement("input");
+        tempInput.value = value;
+        document.body.appendChild(tempInput);
+        tempInput.select();
+        document.execCommand("copy");
+        document.body.removeChild(tempInput);
+    }
 }
 
 window.showTip = showTip;