Skip to content

[Repo Assist] eng: fix stale FCS VersionOverride; replace Enumerable.Cast with Seq.cast #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 2 commits into from
Apr 20, 2026
Merged

[Repo Assist] eng: fix stale FCS VersionOverride; replace Enumerable.Cast with Seq.cast #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc64f79
eng: fix stale FCS VersionOverride; replace Enumerable.Cast with Seq.…
github-actions[bot] Apr 18, 2026
9a66ada
ci: trigger checks
github-actions[bot] Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* Replace deprecated `System.Net.WebClient` with `System.Net.Http.HttpClient` in the image downloader used by `--saveimages`. Removes the `#nowarn "44"` suppression.
* Bump `Newtonsoft.Json` transitive-dependency pin from 13.0.3 to 13.0.4.
* Bump `System.Memory` transitive-dependency pin from 4.5.5 to 4.6.3.0
* Remove stale `VersionOverride="43.12.201"` on the `FSharp.Compiler.Service` reference in `FSharp.Formatting.Markdown.fsproj`; the package now uses the central pin (`43.12.202`) from `Directory.Packages.props`, eliminating the NU1605 build warning.
* Replace `Enumerable.Cast<XAttribute>` (LINQ) with `Seq.cast<XAttribute>` (idiomatic F#) in `MarkdownUtils.fs`, removing the `open System.Linq` import.

### Fixed
* Fix `Markdown.ToMd` silently dropping YAML frontmatter when serialising a parsed `MarkdownDocument` back to Markdown text. Frontmatter is now preserved with its `---` delimiters.
Expand Down
2 changes: 1 addition & 1 deletion src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<ProjectReference Include="..\FSharp.Formatting.Common\FSharp.Formatting.Common.fsproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FSharp.Compiler.Service" VersionOverride="43.12.201" />
<PackageReference Include="FSharp.Compiler.Service" />
<PackageReference Include="FSharp.Core" />
</ItemGroup>
</Project>
3 changes: 1 addition & 2 deletions src/FSharp.Formatting.Markdown/MarkdownUtils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace rec FSharp.Formatting.Markdown

open System
open System.Collections.Generic
open System.Linq
open System.Xml.Linq
open FSharp.Formatting.Templating

Expand Down Expand Up @@ -423,7 +422,7 @@ module internal MarkdownUtils =
let attributes =
match System.Xml.XPath.Extensions.XPathEvaluate(element, "//*/@*[contains(., '.md')]") with
| :? System.Collections.IEnumerable as enumerable ->
enumerable |> Enumerable.Cast<XAttribute> |> Seq.toArray
enumerable |> Seq.cast<XAttribute> |> Seq.toArray
| _ -> Array.empty

if Array.isEmpty attributes then
Expand Down