Skip to content

[Repo Assist] Fix decodeILCustomAttribData: resolve System.Type custom attribute arguments #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 2 commits into from
Apr 1, 2026
Merged

[Repo Assist] Fix decodeILCustomAttribData: resolve System.Type custom attribute arguments #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58bf34d
Fix decodeILCustomAttribData: resolve System.Type custom attribute ar…
github-actions[bot] Mar 31, 2026
72642ad
ci: trigger checks
github-actions[bot] Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/ProvidedTypes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6695,7 +6695,7 @@ module internal AssemblyReader =
let s, sigptr = sigptr_get_string len bytes sigptr
Some(s), sigptr

let decodeILCustomAttribData ilg (resolveEnumUnderlyingILType: ILType -> ILType) (ca: ILCustomAttribute) =
let decodeILCustomAttribData ilg (resolveEnumUnderlyingILType: ILType -> ILType) (resolveILType: ILType -> Type) (ca: ILCustomAttribute) =
let bytes = ca.Data
let sigptr = 0
let bb0, sigptr = sigptr_get_byte bytes sigptr
Expand Down Expand Up @@ -6748,12 +6748,13 @@ module internal AssemblyReader =
| ILType.Boxed tspec when tspec.Namespace = USome "System" && tspec.Name = "Type" ->
let nOpt, sigptr = sigptr_get_serstring_possibly_null bytes sigptr
match nOpt with
| None -> (argty, box null) , sigptr // TODO: read System.Type attrs
| None -> (argty, box null), sigptr
| Some n ->
try
let parser = ILTypeSigParser(n)
parser.ParseType() |> ignore
(argty, box null) , sigptr // TODO: read System.Type attributes
let ilty = parser.ParseType()
let resolvedType = try resolveILType ilty with _ -> null
(argty, box resolvedType), sigptr
with e ->
failwithf "decodeILCustomAttribData: error parsing type in custom attribute blob: %s" e.Message
| ILType.Boxed tspec when tspec.Namespace = USome "System" && tspec.Name = "Object" ->
Expand Down Expand Up @@ -7697,7 +7698,7 @@ namespace ProviderImplementation.ProvidedTypes
else ilGlobals.typ_Int32
with _ -> ilGlobals.typ_Int32
| _ -> ilGlobals.typ_Int32
let args, namedArgs = decodeILCustomAttribData ilGlobals resolveEnumUnderlyingILType inp
let args, namedArgs = decodeILCustomAttribData ilGlobals resolveEnumUnderlyingILType (txILType ([| |], [| |])) inp
{ new CustomAttributeData () with
member __.Constructor = txILConstructorRef inp.Method.MethodRef
member __.ConstructorArguments = [| for arg in args -> txCustomAttributesArg arg |] :> IList<_>
Expand Down
Loading