Conversation
…rete classes with lazy name-lookup caches - Replace abstract interface ILFieldDefs/ILEventDefs/ILPropertyDefs with concrete classes mirroring the existing ILMethodDefs pattern - Each class holds a Lazy<T[]> for entries and a lazy Dictionary<string,T> for O(1) name lookups via TryFindByName - seekReadFields/seekReadEvents/seekReadProperties now pass lazy computations to the constructors, so entries are computed at most once (previously every .Entries access on events/properties re-ran the entire range scan) - TargetTypeDefinition.GetField/GetPropertyImpl/GetEvent now O(1) via lazy fieldDefsMap/propDefsMap/eventDefsMap dictionaries over the wrapped reflection objects - TypeSymbol.GetField/GetPropertyImpl/GetEvent for TargetGeneric now use TryFindByName instead of Array.tryFind - TargetTypeDefinition.GetEnumUnderlyingType uses TryFindByName instead of Array.tryFind for the 'value__' field lookup - All creation sites updated (empty constants, binary reader, ProvidedTypeBuilder) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Apr 15, 2026
- Add GenerativePropertiesTests.fs: 5 new tests covering instance read-only, read-write, static, multi-property name-lookup (exercises ILPropertyDefs lazy FindByName dictionary from #502), and property count on a generative type - 136/136 tests pass - Prepare RELEASE_NOTES.md for 8.6.0 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 15, 2026
dsyme
pushed a commit
that referenced
this pull request
Apr 17, 2026
….6.0 (#504) 🤖 *This is an automated PR from Repo Assist.* ## Summary **Task 9 – Testing Improvements**: Add `GenerativePropertiesTests.fs` with 5 new property tests for generative types. **Task 10 – Take the Repository Forward**: Update `RELEASE_NOTES.md` to prepare release 8.6.0. --- ## Changes ### New: `tests/GenerativePropertiesTests.fs` Five tests covering properties in generative type providers: 1. **Instance read-only property** – presence, type, `CanRead`/`CanWrite`, non-static getter 2. **Instance read-write property** – getter and setter present, correct method names 3. **Static read-only property** – presence, static getter 4. **Name-lookup for all properties** – calls `GetProperty` by name for each of the 4 properties on the generated type; directly exercises the `ILPropertyDefs` lazy `FindByName` dictionary added in #502 5. **Property count** – verifies the correct number of properties is emitted ### Updated: `RELEASE_NOTES.md` Added 8.6.0 entry documenting: - Bug fix: `ProvidedTypeDefinition.Logger` creating a new delegate reference on each call (#501) - Refactor/Performance: `ILFieldDefs`/`ILEventDefs`/`ILPropertyDefs` concrete classes with lazy O(1) name-lookup caches (#502) - These new tests --- ## Test Status ✅ **136/136 tests pass** (baseline was 131; 5 new tests added, all green) ``` Passed! - Failed: 0, Passed: 136, Skipped: 0, Total: 136 ``` > Generated by 🌈 Repo Assist, see [workflow run](https://github.com/fsprojects/FSharp.TypeProviders.SDK/actions/runs/24430249769). [Learn more](https://github.com/githubnext/agentics/blob/main/docs/repo-assist.md). > > To install this [agentic workflow](https://github.com/githubnext/agentics/blob/97143ac59cb3a13ef2a77581f929f06719c7402a/workflows/repo-assist.md), run > ``` > gh aw add githubnext/agentics@97143ac > ``` <!-- gh-aw-agentic-workflow: Repo Assist, engine: copilot, model: auto, id: 24430249769, workflow_id: repo-assist, run: https://github.com/fsprojects/FSharp.TypeProviders.SDK/actions/runs/24430249769 --> <!-- gh-aw-workflow-id: repo-assist --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
This PR converts
ILFieldDefs,ILEventDefs, andILPropertyDefsfrom abstract interfaces to concrete classes, mirroring the existingILMethodDefspattern. It adds lazy O(1) name-lookup caches throughout and makes entries truly lazy (computed at most once per type).Background
Previously these three types were abstract interfaces:
Every name-based lookup (
GetField,GetPropertyImpl,GetEvent,GetEnumUnderlyingType) calledArray.tryFind— an O(n) linear scan. Additionally,seekReadEventsandseekReadPropertiesrecomputed the entries array on every.Entriesaccess (the binary reader range scan ran again each time).Changes
Concrete classes with lazy dict caches — mirroring
ILMethodDefs:Similarly for
ILEventDefsandILPropertyDefs.Entries are now truly lazy —
seekReadEvents/seekReadPropertiespreviously re-ran the range scan on every.Entriescall. Now the lazy constructor caches after first access.O(1) lookups in
TypeSymbolandTargetTypeDefinition:TypeSymbol.GetField/GetPropertyImpl/GetEvent(generic instantiations): now useTryFindByNameinstead ofArray.tryFindTargetTypeDefinition.GetField/GetPropertyImpl/GetEvent: new lazyfieldDefsMap/propDefsMap/eventDefsMapdictionaries over the wrapped reflection objectsTargetTypeDefinition.GetEnumUnderlyingType: usesTryFindByNamefor the"value__"fieldAll creation sites updated: empty constants,
seekReadFields/seekReadEvents/seekReadProperties, andProvidedTypeBuilder.Trade-offs
ILTypeDef(dictionary overhead), but only allocated on first name lookupEntriesstill works identically;TryFindByNameis a new additive methodRelation to issue #500
This PR implements the code improvements from the blocked issue #500 (which was blocked by the inclusion of
.github/dependabot.yml). This PR contains only the code changes, without the Dependabot config.Test Status
✅ 126/126 tests pass (
dotnet test tests/FSharp.TypeProviders.SDK.Tests.fsproj -c Release --framework net8.0)Build:
dotnet build src/FSharp.TypeProviders.SDK.fsproj -c Release— succeeded, 0 warnings, 0 errors.