Conversation
…rete classes with lazy name-lookup dictionaries; add Dependabot config - Convert ILFieldDefs, ILEventDefs, ILPropertyDefs from abstract interface types to concrete classes (mirroring the existing ILMethodDefs pattern). Each class holds a Lazy<T[]> and builds a lazy Dictionary<string, T> for O(1) TryFindByName lookups. - Update all instantiation sites (empty instances, seekReadFields, seekReadEvents, seekReadProperties, binary writer) to use the new constructors. - Add TryFindByName callers in TypeSymbol.GetField/GetPropertyImpl/GetEvent and TargetTypeDefinition.GetEnumUnderlyingType to replace O(n) Array.tryFind scans. - Add lazy fieldDefsMap/propDefsMap/eventDefsMap in TargetTypeDefinition for O(1) single-member lookup in GetField/GetPropertyImpl/GetEvent. - Lazy evaluation of Entries also means repeated .Entries accesses on seekRead-produced ILFieldDefs/ILEventDefs/ILPropertyDefs no longer re-read the underlying metadata on each call. - Also: add .github/dependabot.yml for weekly GitHub Actions updates. - Fix typo: 'occured' -> 'occurred' in error message. 126/126 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rete classes with lazy name-lookup dictionaries; add Dependabot config
Convert ILFieldDefs, ILEventDefs, ILPropertyDefs from abstract interface types to concrete classes (mirroring the existing ILMethodDefs pattern). Each class holds a Lazy<T[]> and builds a lazy Dictionary<string, T> for O(1) TryFindByName lookups.
Update all instantiation sites (empty instances, seekReadFields, seekReadEvents, seekReadProperties, binary writer) to use the new constructors.
Add TryFindByName callers in TypeSymbol.GetField/GetPropertyImpl/GetEvent and TargetTypeDefinition.GetEnumUnderlyingType to replace O(n) Array.tryFind scans.
Add lazy fieldDefsMap/propDefsMap/eventDefsMap in TargetTypeDefinition for O(1) single-member lookup in GetField/GetPropertyImpl/GetEvent.
Lazy evaluation of Entries also means repeated .Entries accesses on seekRead-produced ILFieldDefs/ILEventDefs/ILPropertyDefs no longer re-read the underlying metadata on each call.
Also: add .github/dependabot.yml for weekly GitHub Actions updates.
Fix typo: 'occured' -> 'occurred' in error message.
126/126 tests pass.