Skip to content

Commit e215088

Browse files
committed
#183 Manually added stuff from the PR @bartelink
1 parent 9bd8b2c commit e215088

4 files changed

Lines changed: 12 additions & 9 deletions

File tree

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<PackageReleaseNotes>
1919
14.4.2
20-
- Pinned FSharp.Core to 5.0.2 in all library projects
20+
- Thanks @bartelink: Pinned FSharp.Core to 5.0.2 in all library projects
2121

2222
14.4.1
2323
- Fixed missing explicit dependency on FSharp.Core

src/FsHttp/FsHttp.fsproj

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,17 @@
3636
<None Include="..\..\docs\img\logo_small.png" Pack="true" PackagePath="\" />
3737
</ItemGroup>
3838
<ItemGroup>
39-
<!--
40-
We require F# Core >= 5 due to string interpolation.
41-
AND: We have this in all library projects; NOT in the test projects.
39+
<!--
40+
- Intentionally depend on a minimal version of FSharp.Core as the package previously did prior to V13
41+
see https://github.com/fsprojects/FsHttp/issues/183
42+
- Releases 13-14.4.0 did not include a nuspec declaration of their dependency on FSharp.Core V8.0.100,
43+
so tools like Paket will gravitate toward those broken versions if we make the version constraint more restrictive
44+
- We require F# Core >= 5 due to string interpolation.
45+
- We have this in all library projects; NOT in the test projects.
46+
(https://fsharp.github.io/fsharp-compiler-docs/fsharp-core-notes.html#Package-authors-should-pin-their-FSharp-Core-reference)
47+
- ExcludeAssets is a workaround for malformed FSharp.Core packages https://github.com/dotnet/fsharp/issues/12706 via https://github.com/fsprojects/Paket/issues/4149
48+
Removal triggers issues in dotnet publish, e.g. for Lambda projects
49+
Also avoids Rider search finding stuff in FSharp.Core.xml
4250
-->
4351
<PackageReference Include="FSharp.Core" Version="5.0.2" />
4452
</ItemGroup>

src/Test.CSharp/Test.CSharp.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
<PropertyGroup>
44
<TargetFramework>net8.0</TargetFramework>
55
<Nullable>enable</Nullable>
6-
7-
<IsPackable>false</IsPackable>
86
</PropertyGroup>
97

108
<ItemGroup>

src/Tests/Tests.fsproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
<Project Sdk="Microsoft.NET.Sdk">
33
<PropertyGroup>
44
<TargetFrameworks>net8.0</TargetFrameworks>
5-
<IsPackable>false</IsPackable>
6-
<OutputType>Library</OutputType>
7-
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
85
<Configurations>Debug;Release</Configurations>
96
</PropertyGroup>
107
<ItemGroup>

0 commit comments

Comments
 (0)