Remove duplicated code across ASTTransformer, CodePrinter, Context, Trivia, Daemon#3375
Closed
MelbourneDeveloper wants to merge 3 commits into
Closed
Remove duplicated code across ASTTransformer, CodePrinter, Context, Trivia, Daemon#3375MelbourneDeveloper wants to merge 3 commits into
MelbourneDeveloper wants to merge 3 commits into
Conversation
MelbourneDeveloper
force-pushed
the
mergedupes
branch
from
July 5, 2026 08:45
acd6591 to
bd907ea
Compare
Contributor
|
Thanks for having a go at this. Not a change we want to take on, so I'm closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven byte-identical blocks were copy-pasted across five files, mostly where the impl and sig paths (or the short and long paths) grew by duplication. Each pair folds into one shared definition:
mkAnonRecordFields,mkTypeDefnObjectModelKind,mkModuleOrNamespaceHeaderlongbranch was an identical+>pipeline ofshort, so reuseshorttrimTrailingSpacesparsedInputTriviaconfigForRequestNo behaviour change.
Fixes #3374
Dupes found with Deslop.live
