Yet another fix for isdir#676
Merged
Merged
Conversation
Member
|
This seems to break the batch copy tests. It is plausible, but probably unlikely, that the tests are incorrect - see https://filesystem-spec.readthedocs.io/en/latest/copying.html |
Contributor
Author
|
The tests are correct, and should all pass now. |
martindurant
left a comment
martindurant
left a comment
Member
There was a problem hiding this comment.
OK, looks good. I just have a couple of questions.
Contributor
Author
|
Does this look good now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another stab at a fix for #312.
Empty files that ends with "/" are treated as empty directories in "ls" and "info".
Test requsted in #313 is added.