Skip to content

Fix Storage Control endpoint resolution for TPC#847

Open
Mahalaxmibejugam wants to merge 6 commits into
fsspec:mainfrom
ankitaluthra1:tpc-testing
Open

Fix Storage Control endpoint resolution for TPC#847
Mahalaxmibejugam wants to merge 6 commits into
fsspec:mainfrom
ankitaluthra1:tpc-testing

Conversation

@Mahalaxmibejugam
Copy link
Copy Markdown
Collaborator

This PR fixes the endpoint resolution for the Storage Control API in ExtendedGcsFileSystem to support TPC environments correctly.

Changes

  • gcsfs/extended_gcsfs.py: Refactored _get_control_plane_client to use self._location for deriving the endpoint, automatically handling universe domains and emulator hosts.
  • gcsfs/tests/test_extended_hns_gcsfs.py: Added test_get_control_plane_client_endpoint to cover explicit endpoint, universe domain, emulator, and default fallback scenarios.
  • cloudbuild/setup_vm.sh: Added a log to print the fsspec version after installing it from head, to help debug CI issues.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.95%. Comparing base (e768973) to head (c7f1f7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   88.19%   87.95%   -0.24%     
==========================================
  Files          15       15              
  Lines        2989     2997       +8     
==========================================
  Hits         2636     2636              
- Misses        353      361       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant