Commit 7f126e0
authored
feat (Frame): Accept all supported options to
The corresponding change to be able to use [#49 from
playwright_ex](ftes/playwright_ex#49). The
description from that PR:
> This expands the list of selected options for
`PlaywrightEx.Frame.goto/2` to match those of the JavaScript API
([docs](https://playwright.dev/docs/api/class-page#page-goto)).
>
> I found that in CI, I was often hitting 30 second timeouts waiting for
the `load` event—even though in the trace, I could clearly see the page
had (at least conceptually!) loaded. When switching to `waitUntil:
'commit'` (rather than the default `waitUntil: 'load'`), not only did
the flakiness of that initial page load get fixed, but the tests also
got _much_ faster: from an average of >5 seconds per test down to under
1.5 seconds/test.
>
> (The `Referer` stuff isn't strictly necessary for my own work, but I
figured while I was in here, I might as well make `goto` accept
everything the JavaScript version does.)
It doesn't feel _great_ having the docs copied and pasted between the
two projects, but it seemed cleaner than, say, exposing a function from
PlaywrightEx that would provide the options at compile-time.goto (#171)1 parent 03af45b commit 7f126e0
1 file changed
Lines changed: 19 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
159 | 177 | | |
160 | 178 | | |
161 | 179 | | |
| |||
0 commit comments