fix(assert_has): Fix for failure to match when a hidden text match precedes a visible one in DOM order#195
Merged
Merged
Conversation
…recedes a visible one in DOM order Before: `"css=#hidden-text-repro >> visible=true >> internal:text=\"Text to find\"i"` After: `"css=#hidden-text-repro >> internal:text=\"Text to find\"i >> visible=true"` Resolves ftes#194
Owner
|
Wonderful, thanks Tyler. Also verified on an existing large code base. |
ftes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
assert_has(selector, text: ...)would fail if there was a hidden DOM node that matched the text before a visible one.Comparing the
selectorgenerated inPhoenixTest.Playwright.found?/4:"css=#hidden-text-repro >> visible=true >> internal:text=\"Text to find\"i""css=#hidden-text-repro >> internal:text=\"Text to find\"i >> visible=true"Resolves #194