Skip to content

Add support for Tokio Command#130

Open
itpetey wants to merge 2 commits into
fubarnetes:devfrom
itpetey:dev
Open

Add support for Tokio Command#130
itpetey wants to merge 2 commits into
fubarnetes:devfrom
itpetey:dev

Conversation

@itpetey
Copy link
Copy Markdown

@itpetey itpetey commented Jun 17, 2023

No description provided.

@igalic
Copy link
Copy Markdown

igalic commented Jun 17, 2023

and what does that do?

@itpetey
Copy link
Copy Markdown
Author

itpetey commented Jun 17, 2023

Tokio Command? It's an async version of the std lib, which sits on top of Tokio's runtime.

https://docs.rs/tokio/1.28.2/tokio/process/struct.Command.html

@asomers
Copy link
Copy Markdown
Collaborator

asomers commented Jun 17, 2023

What primitives does it use? I guess it probably uses asynchronous pipe APIs for stdin and stdout. But does it spawn a thread for wait or use kqueue's EVFILT_PROC to detect when the child has exited?

@itpetey
Copy link
Copy Markdown
Author

itpetey commented Jun 18, 2023

I'm not a Tokio dev, so I don't know what's under the hood. However I do know that Tokio sits on top of Metal I/O, which explicitly supports FreeBSD: https://github.com/tokio-rs/mio.

@fabianfreyer
Copy link
Copy Markdown
Contributor

LGTM!

@asomers
Copy link
Copy Markdown
Collaborator

asomers commented May 6, 2025

I think this is a good feature. But it needs:

  • A rebase
  • A test
  • A CHANGELOG entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants