add check for collaborator

Author: eksrha

src/acigithub/github-client.go

@@ -18,6 +18,10 @@ var (
 	githubRepository, isgithubRepository = os.LookupEnv("GITHUB_REPOSITORY")
 	githubToken, isgithubToken           = os.LookupEnv("GITHUB_TOKEN")
 	owner, repo                          string
+	standardListOptions                  = github.ListOptions{
+		PerPage: 100,
+		Page:    1,
+	}
 )
 
 // NewGitHubClient Creates a new GitHub Client

src/acigithub/issues.go

@@ -18,12 +18,9 @@ func GetIssueComments(issueNumber int) (issueComments []*github.IssueComment, er
 	//FIXME: currently the GitHub API ignores Direction and Sort
 	// so, we are using the default settings for the query and sorting the response afterwards
 	var commentOpts = &github.IssueListCommentsOptions{
-		Direction: &direction,
-		Sort:      &sort,
-		ListOptions: github.ListOptions{
-			PerPage: 100,
-			Page:    1,
-		},
+		Direction:   &direction,
+		Sort:        &sort,
+		ListOptions: standardListOptions,
 	}
 	issueComments, _, err = GithubClient.Issues.ListComments(ctx, owner, repo, issueNumber, commentOpts)
 
@@ -49,12 +46,9 @@ func CommentHelpToPullRequest(number int) (err error) {
 	}
 
 	var commentOpts = &github.IssueListCommentsOptions{
-		Direction: &direction,
-		Sort:      &sort,
-		ListOptions: github.ListOptions{
-			PerPage: 100,
-			Page:    1,
-		},
+		Direction:   &direction,
+		Sort:        &sort,
+		ListOptions: standardListOptions,
 	}
 	comments, _, err := GithubClient.Issues.ListComments(ctx, owner, repo, number, commentOpts)
 	if err != nil {

src/acigithub/pullrequest.go

@@ -8,7 +8,6 @@ import (
 	"log"
 	"os"
 	"regexp"
-	"strings"
 
 	"github.com/google/go-github/v39/github"
 )
@@ -76,13 +75,15 @@ func GetPrInfos(prNumber int, mergeCommitSha string) (standardPrInfos *models.St
 	if err != nil {
 		return nil, nil, err
 	}
+
 	for _, comment := range issueComments {
-		// Must have permission in the repo to create a major version
-		// MANNEQUIN|NONE https://docs.github.com/en/graphql/reference/enums#commentauthorassociation
-		log.Println(*comment.AuthorAssociation)
-		log.Println(*comment.Body)
-		log.Println(*comment.User)
-		if strings.Contains("MEMBER|OWNER|CONTRIBUTOR|COLLABORATOR", *comment.AuthorAssociation) {
+		// Must be a collaborator to have permission to create an override
+		isCollaborator, _, err := GithubClient.Repositories.IsCollaborator(ctx, owner, repo, *comment.User.Login)
+		if err != nil {
+			return nil, nil, err
+		}
+
+		if isCollaborator {
 			aciVersionOverride := regexp.MustCompile(`aci_version_override: ([0-9]+\.[0-9]+\.[0-9]+)`)
 			aciPatchLevel := regexp.MustCompile(`aci_patch_level: ([a-zA-Z]+)`)