feat(cli): implement upgrade check (Sprint 2) (#1196) #102
ci.yml
on: push
Build
1m 40s
Matrix: test
Publish Dev Containers
1m 41s
Publish Release (NuGet + Containers)
0s
Annotations
14 warnings
|
Build:
src/Tools/CLI/Services/GitHubReleaseService.cs#L118
Make 'GetPackagesPropsAsync' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
|
Build:
src/Tools/CLI/Commands/VersionCommand.cs#L123
Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869)
|
|
Build:
src/Tools/CLI/Services/GitHubReleaseService.cs#L94
Modify 'GitHubReleaseService.GetReleaseByTagAsync(string,
|
|
Build:
src/Tools/CLI/Services/GitHubReleaseService.cs#L66
Modify 'GitHubReleaseService.GetReleasesAsync([int],
|
|
Build:
src/Tools/CLI/Services/GitHubReleaseService.cs#L38
Modify 'GitHubReleaseService.GetLatestReleaseAsync([CancellationToken])' to call 'HttpClient.GetAsync(Uri, CancellationToken)' instead of 'HttpClient.GetAsync(string, CancellationToken)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2234)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L140
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.CLI.Services.VersionComparer.ParseVersionParts(string)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L118
Remove this unused method parameter 'package'. (https://rules.sonarsource.com/csharp/RSPEC-1172)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L126
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
Build:
src/Tools/CLI/Services/VersionComparer.cs#L34
Modify 'ParsePackagesProps' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build:
src/Tools/CLI/Commands/UpgradeCommand.cs#L258
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Publish Dev Containers:
src/Modules/Identity/Modules.Identity/Services/IdentityService.cs#L180
Member 'CreateBasicClaims' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Publish Dev Containers:
src/Modules/Identity/Modules.Identity/Services/IdentityService.cs#L180
Make 'CreateBasicClaims' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
|
Publish Dev Containers:
src/BuildingBlocks/Mailing/Services/SmtpMailService.cs#L49
Member 'ConfigureRecipients' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Publish Dev Containers:
src/BuildingBlocks/Mailing/Services/SmtpMailService.cs#L49
Make 'ConfigureRecipients' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
build-output
Expired
|
138 MB |
sha256:bfbd93aa58be8e1f2dee89472f882a66036e7d1eaa49893f66cadc04a31e3c56
|
|