FullStackHero 10 .NET Starter Kit Release Merge #324
ci.yml
on: pull_request
Build
1m 15s
Matrix: test
Publish Dev Containers
0s
Publish Release (NuGet + Containers)
0s
Annotations
10 errors
|
Build:
src/Modules/Billing/Modules.Billing/Services/BillingService.cs#L93
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
Build:
src/Modules/Billing/Modules.Billing/Services/BillingService.cs#L45
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
Build:
src/Modules/Billing/Modules.Billing/Services/MonthlyInvoiceJob.cs#L28
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
Build:
src/Modules/Billing/Modules.Billing/Services/MonthlyInvoiceJob.cs#L24
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
Build:
src/Modules/Billing/Modules.Billing/Services/UsageReporter.cs#L65
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
Build:
src/BuildingBlocks/Quota/NoopQuotaService.cs#L9
'NoopQuotaService' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)
|
|
Build:
src/BuildingBlocks/Quota/InMemoryQuotaStore.cs#L9
'InMemoryQuotaStore' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)
|
|
Build:
src/BuildingBlocks/Quota/RedisQuotaService.cs#L21
Change type of field '_gauges' from 'System.Collections.Generic.IReadOnlyDictionary<FSH.Framework.Shared.Quota.QuotaResource, FSH.Framework.Quota.IQuotaGaugeProvider>' to 'System.Collections.Generic.Dictionary<FSH.Framework.Shared.Quota.QuotaResource, FSH.Framework.Quota.IQuotaGaugeProvider>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
Build:
src/BuildingBlocks/Quota/InMemoryQuotaService.cs#L18
Change type of field '_gauges' from 'System.Collections.Generic.IReadOnlyDictionary<FSH.Framework.Shared.Quota.QuotaResource, FSH.Framework.Quota.IQuotaGaugeProvider>' to 'System.Collections.Generic.Dictionary<FSH.Framework.Shared.Quota.QuotaResource, FSH.Framework.Quota.IQuotaGaugeProvider>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
Build:
src/BuildingBlocks/Quota/QuotaOptions.cs#L23
Change 'Plans' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|