Skip to content

Commit 4dfadf9

Browse files
iammukeshmjarvis
andauthored
fix: resolve all build warnings (#1183)
* fix: Add logging to session creation exception in GenerateTokenCommandHandler Fixes #1179 The catch block was swallowing exceptions silently. While the behavior is intentional (session creation failure shouldn't block login), the exception should be logged for debugging purposes. Changes: - Added ILogger<GenerateTokenCommandHandler> dependency - Log warning when session creation fails with exception details * fix: resolve all build warnings - Change navigation property setters from 'private set' to 'init' for EF Core entities (fixes S1144) - GroupRole.cs: Group, Role properties - PasswordHistory.cs: Id, User properties - UserGroup.cs: User, Group properties - UserSession.cs: User property - Add await to InvokeAsync(StateHasChanged) calls in PlaygroundLayout.razor (fixes CS4014) Build now completes with 0 warnings, 0 errors. --------- Co-authored-by: jarvis <jarvis@codewithmukesh.com>
1 parent ddb2b4f commit 4dfadf9

5 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/Modules/Identity/Modules.Identity/Domain/GroupRole.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ public class GroupRole
55
public Guid GroupId { get; private set; }
66
public string RoleId { get; private set; } = default!;
77

8-
// Navigation properties
9-
public virtual Group? Group { get; private set; }
10-
public virtual FshRole? Role { get; private set; }
8+
// Navigation properties (init for EF Core materialization)
9+
public virtual Group? Group { get; init; }
10+
public virtual FshRole? Role { get; init; }
1111

1212
private GroupRole() { } // EF Core
1313

src/Modules/Identity/Modules.Identity/Domain/PasswordHistory.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ namespace FSH.Modules.Identity.Domain;
22

33
public class PasswordHistory
44
{
5-
public int Id { get; private set; }
5+
public int Id { get; init; }
66
public string UserId { get; private set; } = default!;
77
public string PasswordHash { get; private set; } = default!;
88
public DateTime CreatedAt { get; private set; }
99

10-
// Navigation property
11-
public virtual FshUser? User { get; private set; }
10+
// Navigation property (init for EF Core materialization)
11+
public virtual FshUser? User { get; init; }
1212

1313
private PasswordHistory() { } // EF Core
1414

src/Modules/Identity/Modules.Identity/Domain/UserGroup.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ public class UserGroup
77
public DateTime AddedAt { get; private set; }
88
public string? AddedBy { get; private set; }
99

10-
// Navigation properties
11-
public virtual FshUser? User { get; private set; }
12-
public virtual Group? Group { get; private set; }
10+
// Navigation properties (init for EF Core materialization)
11+
public virtual FshUser? User { get; init; }
12+
public virtual Group? Group { get; init; }
1313

1414
private UserGroup() { } // EF Core
1515

src/Modules/Identity/Modules.Identity/Domain/UserSession.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public class UserSession
2020
public string? RevokedBy { get; private set; }
2121
public string? RevokedReason { get; private set; }
2222

23-
// Navigation property
24-
public virtual FshUser? User { get; private set; }
23+
// Navigation property (init for EF Core materialization)
24+
public virtual FshUser? User { get; init; }
2525

2626
private UserSession() { } // EF Core
2727

src/Playground/Playground.Blazor/Components/Layout/PlaygroundLayout.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ else
182182
_isDarkMode = TenantThemeState.IsDarkMode;
183183
_logoUrl = _isDarkMode ? TenantThemeState.Current.BrandAssets.LogoDarkUrl : TenantThemeState.Current.BrandAssets.LogoUrl;
184184

185-
InvokeAsync(StateHasChanged);
185+
await InvokeAsync(StateHasChanged);
186186
}
187187
else if (wasAuthenticated && !_isAuthenticated)
188188
{
@@ -192,7 +192,7 @@ else
192192
_isDarkMode = false;
193193
_logoUrl = null;
194194
await ApplyFaviconAsync(); // reset to default
195-
InvokeAsync(StateHasChanged);
195+
await InvokeAsync(StateHasChanged);
196196
}
197197
}
198198

0 commit comments

Comments
 (0)