fix more warnings

Author: iammukeshm

src/BuildingBlocks/Caching/DistributedCacheService.cs

@@ -99,15 +99,14 @@ private DistributedCacheEntryOptions BuildEntryOptions(TimeSpan? sliding)
     private string Normalize(string key)
     {
         if (string.IsNullOrWhiteSpace(key)) throw new ArgumentNullException(nameof(key));
-        if (key.StartsWith(_opts.KeyPrefix, StringComparison.Ordinal))
+        var prefix = _opts.KeyPrefix ?? string.Empty;
+        if (prefix.Length == 0)
         {
-            return string.IsNullOrWhiteSpace(_opts.KeyPrefix) ? key :
-               key;
-        }
-        else
-        {
-            return string.IsNullOrWhiteSpace(_opts.KeyPrefix) ? key :
-               (_opts.KeyPrefix + key);
+            return key;
         }
+
+        return key.StartsWith(prefix, StringComparison.Ordinal)
+            ? key
+            : prefix + key;
     }
 }

src/BuildingBlocks/Core/Exceptions/CustomException.cs

@@ -1,4 +1,5 @@
-using System.Net;
+using System.Net;
+using System.Linq;
 
 namespace FSH.Framework.Core.Exceptions;
 
@@ -18,9 +19,24 @@ public class CustomException : Exception
     /// </summary>
     public HttpStatusCode StatusCode { get; }
 
+    public CustomException()
+        : this("An error occurred.", Enumerable.Empty<string>(), HttpStatusCode.InternalServerError)
+    {
+    }
+
+    public CustomException(string message)
+        : this(message, Enumerable.Empty<string>(), HttpStatusCode.InternalServerError)
+    {
+    }
+
+    public CustomException(string message, Exception innerException)
+        : this(message, innerException, Enumerable.Empty<string>(), HttpStatusCode.InternalServerError)
+    {
+    }
+
     public CustomException(
         string message,
-        IEnumerable<string>? errors = null,
+        IEnumerable<string>? errors,
         HttpStatusCode statusCode = HttpStatusCode.InternalServerError)
         : base(message)
     {
@@ -31,11 +47,19 @@ public CustomException(
     public CustomException(
         string message,
         Exception innerException,
-        IEnumerable<string>? errors = null,
+        IEnumerable<string>? errors,
         HttpStatusCode statusCode = HttpStatusCode.InternalServerError)
         : base(message, innerException)
     {
         ErrorMessages = errors?.ToList() ?? new List<string>();
         StatusCode = statusCode;
     }
-}
+
+    public CustomException(
+        string message,
+        Exception innerException,
+        HttpStatusCode statusCode)
+        : this(message, innerException, Enumerable.Empty<string>(), statusCode)
+    {
+    }
+}

src/BuildingBlocks/Core/Exceptions/ForbiddenException.cs

@@ -20,4 +20,9 @@ public ForbiddenException(string message, IEnumerable<string> errors)
         : base(message, errors.ToList(), HttpStatusCode.Forbidden)
     {
     }
-}
+
+    public ForbiddenException(string message, Exception innerException)
+        : base(message, innerException, HttpStatusCode.Forbidden)
+    {
+    }
+}

src/BuildingBlocks/Core/Exceptions/NotFoundException.cs

@@ -7,6 +7,11 @@ namespace FSH.Framework.Core.Exceptions;
 /// </summary>
 public class NotFoundException : CustomException
 {
+    public NotFoundException()
+        : base("Resource not found.", Array.Empty<string>(), HttpStatusCode.NotFound)
+    {
+    }
+
     public NotFoundException(string message)
         : base(message, Array.Empty<string>(), HttpStatusCode.NotFound)
     {
@@ -16,4 +21,9 @@ public NotFoundException(string message, IEnumerable<string> errors)
         : base(message, errors.ToList(), HttpStatusCode.NotFound)
     {
     }
-}
+
+    public NotFoundException(string message, Exception innerException)
+        : base(message, innerException, HttpStatusCode.NotFound)
+    {
+    }
+}

src/BuildingBlocks/Core/Exceptions/UnauthorizedException.cs

@@ -20,4 +20,9 @@ public UnauthorizedException(string message, IEnumerable<string> errors)
         : base(message, errors.ToList(), HttpStatusCode.Unauthorized)
     {
     }
-}
+
+    public UnauthorizedException(string message, Exception innerException)
+        : base(message, innerException, HttpStatusCode.Unauthorized)
+    {
+    }
+}

src/BuildingBlocks/Eventing/Eventing.csproj

@@ -6,6 +6,7 @@
     <Nullable>enable</Nullable>
     <RootNamespace>FSH.Framework.Eventing</RootNamespace>
     <AssemblyName>FSH.Framework.Eventing</AssemblyName>
+    <NoWarn>CA1711;CA1716;CA1031;S2139;S1066</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/BuildingBlocks/Eventing/InMemory/InMemoryEventBus.cs

@@ -55,6 +55,11 @@ private async Task PublishSingleAsync(IIntegrationEvent @event, CancellationToke
 
         foreach (var handler in handlers)
         {
+            if (handler is null)
+            {
+                continue;
+            }
+
             var handlerName = handler.GetType().FullName ?? handler.GetType().Name;
 
             if (inbox != null)

src/BuildingBlocks/Jobs/Extensions.cs

@@ -66,7 +66,7 @@ public static IApplicationBuilder UseHeroJobDashboard(this IApplicationBuilder a
 
         var hangfireOptions = config.GetSection(nameof(HangfireOptions)).Get<HangfireOptions>() ?? new HangfireOptions();
         var dashboardOptions = new DashboardOptions();
-        dashboardOptions.AppPath = "https://fullstackhero.net/";
+        dashboardOptions.AppPath = "/";
         dashboardOptions.Authorization = new[]
         {
            new HangfireCustomBasicAuthenticationFilter

src/BuildingBlocks/Jobs/LogJobFilter.cs

@@ -124,6 +124,7 @@ private static string FormatArguments(IReadOnlyList<object?> args)
             return "[]";
         }
 
+        #pragma warning disable CA1031 // best-effort formatting for diagnostics
         try
         {
             var rendered = args.Select(a => a?.ToString() ?? "null");
@@ -133,5 +134,6 @@ private static string FormatArguments(IReadOnlyList<object?> args)
         {
             return "[<unavailable>]";
         }
+        #pragma warning restore CA1031
     }
 }

src/BuildingBlocks/Mailing/Services/SmtpMailService.cs

@@ -79,6 +79,7 @@ public async Task SendAsync(MailRequest request, CancellationToken ct)
         catch (Exception ex)
         {
             _logger.LogError(ex, "An error occurred while sending email: {Message}", ex.Message);
+            throw new InvalidOperationException("Failed to send email.", ex);
         }
         finally
         {