Skip to content

Commit bf81106

Browse files
iammukeshmclaude
andcommitted
chore: .NET 10 housekeeping and doc correctness fixes
- Drop `dotnet workload install aspire` (devcontainer postCreate + template README prerequisite): .NET 10 ships Aspire as NuGet packages, no workload. - DbMigrator is a console Generic Host, so its env gate reads DOTNET_ENVIRONMENT, not ASPNETCORE_ENVIRONMENT — fix the seed-demo refusal message + docs that told users to set the wrong variable. - fsh CLI: the `new` example used the non-existent `--no-git`; use `--no-frontend`. - CONTRIBUTING: Node.js 20+ to match both READMEs (was 22+). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a2ab44a commit bf81106

7 files changed

Lines changed: 6 additions & 7 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"features": {
55
"ghcr.io/devcontainers/features/docker-in-docker:2": {}
66
},
7-
"postCreateCommand": "dotnet workload install aspire && dotnet restore src/FSH.Starter.slnx",
7+
"postCreateCommand": "dotnet restore src/FSH.Starter.slnx",
88
"forwardPorts": [5030, 7030, 15888],
99
"customizations": {
1010
"vscode": {

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Thanks for helping out. The conventions below keep PRs reviewable.
1010

1111
## Dev setup
1212

13-
Prerequisites: .NET 10 SDK, Docker, Node.js 22+.
13+
Prerequisites: .NET 10 SDK, Docker, Node.js 20+.
1414

1515
```bash
1616
dotnet build src/FSH.Starter.slnx

README-template.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ the shared code lives in `src/BuildingBlocks` and is yours to change.
1212
- [.NET 10 SDK](https://dotnet.microsoft.com/download/dotnet/10.0)
1313
- [Node.js 20+](https://nodejs.org) — for the React apps
1414
- [Docker](https://www.docker.com/) — Postgres, Redis, MinIO (orchestrated by Aspire)
15-
- .NET Aspire workload: `dotnet workload install aspire`
1615

1716
## Quick start
1817

src/Host/FSH.Starter.DbMigrator/MigratorCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ apply Apply pending migrations (default). Use --seed to also run SeedA
6666
seed Run only the SeedAsync step per tenant.
6767
seed-demo Provision the demo tenants (acme, globex) with users, catalog,
6868
tickets, and chat. Dev-only — refuses to run unless
69-
ASPNETCORE_ENVIRONMENT=Development.
69+
DOTNET_ENVIRONMENT=Development.
7070
list-pending Print pending migrations without applying anything.
7171
7272
Options:

src/Host/FSH.Starter.DbMigrator/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ await Console.Out.WriteLineAsync(
291291
if (!env.IsDevelopment())
292292
{
293293
await Console.Error.WriteLineAsync(
294-
$"[demo-seed] REFUSING to run — ASPNETCORE_ENVIRONMENT is '{env.EnvironmentName}'. "
294+
$"[demo-seed] REFUSING to run — DOTNET_ENVIRONMENT is '{env.EnvironmentName}'. "
295295
+ "seed-demo is dev-only by design.")
296296
.ConfigureAwait(false);
297297
return 1;

src/Host/FSH.Starter.DbMigrator/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ dotnet run --project src/Host/FSH.Starter.DbMigrator -- seed
4343
# Dev only — provision the demo tenants (acme, globex) with users,
4444
# custom roles, sample catalog, tickets, and chat. Hard-refuses outside
4545
# Development. Idempotent: safe to re-run.
46-
ASPNETCORE_ENVIRONMENT=Development \
46+
DOTNET_ENVIRONMENT=Development \
4747
dotnet run --project src/Host/FSH.Starter.DbMigrator -- seed-demo
4848
```
4949

src/Tools/CLI/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
config.AddCommand<NewCommand>("new")
1919
.WithDescription("Create a new FullStackHero .NET project.")
2020
.WithExample("new", "MyApp")
21-
.WithExample("new", "MyApp", "--no-aspire", "--no-git");
21+
.WithExample("new", "MyApp", "--no-aspire", "--no-frontend");
2222

2323
config.AddCommand<DoctorCommand>("doctor")
2424
.WithDescription("Check your development environment for required tools.");

0 commit comments

Comments
 (0)