fix: Add logging to session creation exception in GenerateTokenCommandHandler (#1182)

Fixes #1179

The catch block was swallowing exceptions silently. While the behavior
is intentional (session creation failure shouldn't block login), the
exception should be logged for debugging purposes.

Changes:
- Added ILogger<GenerateTokenCommandHandler> dependency
- Log warning when session creation fails with exception details

Co-authored-by: jarvis <jarvis@codewithmukesh.com>

Author: iammukeshm

.vscode/launch.json

@@ -0,0 +1,18 @@
+{
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Launch API",
+            "type": "coreclr",
+            "request": "launch",
+            "preLaunchTask": "build",
+            "program": "${workspaceFolder}/src/Playground/Playground.Api/bin/Debug/net10.0/FSH.Playground.Api.dll",
+            "args": [],
+            "cwd": "${workspaceFolder}/src/Playground/Playground.Api",
+            "stopAtEntry": false,
+            "env": {
+                "ASPNETCORE_ENVIRONMENT": "Development"
+            }
+        }
+    ]
+}

.vscode/settings.json

@@ -0,0 +1,11 @@
+{
+    "dotnet.dotnetPath": "/home/jarvis/.dotnet/dotnet",
+    "omnisharp.dotnetPath": "/home/jarvis/.dotnet",
+    "omnisharp.sdkPath": "/home/jarvis/.dotnet/sdk/10.0.102",
+    "omnisharp.useModernNet": true,
+    "editor.formatOnSave": true,
+    "files.exclude": {
+        "**/bin": true,
+        "**/obj": true
+    }
+}

.vscode/tasks.json

@@ -0,0 +1,76 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "build",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "build",
+                "${workspaceFolder}/src/FSH.Framework.slnx",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "problemMatcher": "$msCompile",
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            }
+        },
+        {
+            "label": "test",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "test",
+                "${workspaceFolder}/src/FSH.Framework.slnx"
+            ],
+            "problemMatcher": "$msCompile",
+            "group": "test"
+        },
+        {
+            "label": "run (Aspire)",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "run",
+                "--project",
+                "${workspaceFolder}/src/Playground/FSH.Playground.AppHost"
+            ],
+            "problemMatcher": "$msCompile",
+            "group": "none"
+        },
+        {
+            "label": "run (API only)",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "run",
+                "--project",
+                "${workspaceFolder}/src/Playground/Playground.Api"
+            ],
+            "problemMatcher": "$msCompile",
+            "group": "none"
+        },
+        {
+            "label": "clean",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "clean",
+                "${workspaceFolder}/src/FSH.Framework.slnx"
+            ],
+            "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "restore",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "restore",
+                "${workspaceFolder}/src/FSH.Framework.slnx"
+            ],
+            "problemMatcher": "$msCompile"
+        }
+    ]
+}

src/Modules/Identity/Modules.Identity/Features/v1/Tokens/TokenGeneration/GenerateTokenCommandHandler.cs

@@ -9,6 +9,7 @@
 using FSH.Framework.Eventing.Outbox;
 using FSH.Framework.Shared.Multitenancy;
 using FSH.Modules.Identity.Contracts.Events;
+using Microsoft.Extensions.Logging;
 
 namespace FSH.Modules.Identity.Features.v1.Tokens.TokenGeneration;
 
@@ -22,6 +23,7 @@ public sealed class GenerateTokenCommandHandler
     private readonly IOutboxStore _outboxStore;
     private readonly IMultiTenantContextAccessor<AppTenantInfo> _multiTenantContextAccessor;
     private readonly ISessionService _sessionService;
+    private readonly ILogger<GenerateTokenCommandHandler> _logger;
 
     public GenerateTokenCommandHandler(
         IIdentityService identityService,
@@ -30,7 +32,8 @@ public GenerateTokenCommandHandler(
         IRequestContext requestContext,
         IOutboxStore outboxStore,
         IMultiTenantContextAccessor<AppTenantInfo> multiTenantContextAccessor,
-        ISessionService sessionService)
+        ISessionService sessionService,
+        ILogger<GenerateTokenCommandHandler> logger)
     {
         _identityService = identityService;
         _tokenService = tokenService;
@@ -39,6 +42,7 @@ public GenerateTokenCommandHandler(
         _outboxStore = outboxStore;
         _multiTenantContextAccessor = multiTenantContextAccessor;
         _sessionService = sessionService;
+        _logger = logger;
     }
 
     public async ValueTask<TokenResponse> Handle(
@@ -99,10 +103,11 @@ await _sessionService.CreateSessionAsync(
                 token.RefreshTokenExpiresAt,
                 cancellationToken);
         }
-        catch (Exception)
+        catch (Exception ex)
         {
             // Session creation is non-critical - don't fail the login
             // This can happen if migrations haven't been applied yet
+            _logger.LogWarning(ex, "Failed to create user session for user {UserId}. Login will continue without session tracking.", subject);
         }
 
         // 3) Audit token issuance with a fingerprint (never raw token)