fix: Add CancellationToken to Identity handlers#1169
Merged
Conversation
added 2 commits
January 25, 2026 15:03
- ChangePasswordEndpoint: Add RequireAuthorization() for logged-in users - GetUserProfileEndpoint: Add RequireAuthorization() for logged-in users - AssignUserRolesEndpoint: Add RequirePermission(Users.ManageRoles) - GetUserPermissionsEndpoint: Add RequirePermission(Users.View) - Add Users.ManageRoles permission constant These endpoints were previously accessible without proper authorization checks.
- PathAwareAuthorizationHandler: Pass context.RequestAborted to WriteAsync - RequiredPermissionAuthorizationHandler: Extract CancellationToken from HttpContext and pass to HasPermissionAsync Note: UserRegisteredEmailHandler and TokenGeneratedLogHandler already have proper CancellationToken handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds proper CancellationToken handling to Identity authorization handlers.
Changes
PathAwareAuthorizationHandler.cs
context.RequestAbortedtoWriteAsynccall for proper cancellation supportRequiredPermissionAuthorizationHandler.cs
HttpContext.RequestAbortedwhen availableHasPermissionAsynccall.ConfigureAwait(false)for better async performanceNotes
The other handlers mentioned (
UserRegisteredEmailHandlerandTokenGeneratedLogHandler) were reviewed and already have proper CancellationToken handling:UserRegisteredEmailHandlerpasses thectparameter to_mailService.SendAsyncTokenGeneratedLogHandleronly performs synchronous logging (no async calls)Testing
These changes are backwards compatible and improve request cancellation handling without changing functionality.