fix: resolve all build warnings#1183
Merged
Merged
Conversation
added 2 commits
January 25, 2026 17:34
…dHandler Fixes #1179 The catch block was swallowing exceptions silently. While the behavior is intentional (session creation failure shouldn't block login), the exception should be logged for debugging purposes. Changes: - Added ILogger<GenerateTokenCommandHandler> dependency - Log warning when session creation fails with exception details
- Change navigation property setters from 'private set' to 'init' for EF Core entities (fixes S1144) - GroupRole.cs: Group, Role properties - PasswordHistory.cs: Id, User properties - UserGroup.cs: User, Group properties - UserSession.cs: User property - Add await to InvokeAsync(StateHasChanged) calls in PlaygroundLayout.razor (fixes CS4014) Build now completes with 0 warnings, 0 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 9 build warnings to achieve a clean build with 0 warnings, 0 errors.
Changes
SonarQube S1144 - Unused private setters (7 warnings)
Changed EF Core navigation property setters from
private settoinitin Identity domain entities:GroupRole.cs: Group, Role propertiesPasswordHistory.cs: Id, User propertiesUserGroup.cs: User, Group propertiesUserSession.cs: User propertyUsing
initis EF Core compatible and eliminates the "unused private setter" warning since the setter is now an init accessor.CS4014 - Un-awaited async calls (2 warnings)
Added
awaittoInvokeAsync(StateHasChanged)calls inPlaygroundLayout.razor(lines 185, 195).Build Verification