feat: Add CancellationToken to async methods (#1175)#1191
Merged
iammukeshm merged 1 commit intodevelopfrom Jan 26, 2026
Merged
Conversation
- Add CancellationToken parameter to IdentityDbInitializer private methods and propagate from SeedAsync to all inner async calls - Add CancellationToken to IRoleService interface methods - Update RoleService to accept and propagate CancellationToken - Update all command/query handlers to pass CancellationToken to service This ensures proper cancellation support throughout the identity module for graceful shutdown and request cancellation scenarios.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CancellationToken parameter to async methods that were missing it and propagates the token to all inner async calls.
Changes
IdentityDbInitializer.cs
SeedRolesAsync,AssignPermissionsToRoleAsync,SeedSystemGroupsAsync,SeedAdminUserAsyncSeedAsyncto all inner async callsSingleOrDefaultAsync,FirstOrDefaultAsync,AddAsync,SaveChangesAsyncIRoleService.cs & RoleService.cs
cancellationToken.ThrowIfCancellationRequested()check in loopsCommand/Query Handlers
Notes
HttpContext.RequestAbortedcorrectlyBuild
✅ Build succeeded with 0 errors, 0 new warnings
Closes #1175