Skip to content

Commit b39e09f

Browse files
committed
fix: respect variant_exclusions in contributor CI workflow
Use variants_for_ruby_version(rpv) instead of raw variants to skip malloctrim for Ruby >= 3.3, consistent with the main CI workflow.
1 parent aef213d commit b39e09f

2 files changed

Lines changed: 18 additions & 60 deletions

File tree

.github/workflows/ci-cd-contributor.yml

Lines changed: 15 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
### Download sources ###
148148

149149
- name: Download Ruby source
150-
run: curl -fsSL -o ruby-src.tar.gz 'https://cache.ruby-lang.org/pub/ruby/3.4/ruby-3.4.8.tar.gz'
150+
run: curl -fsSL -o ruby-src.tar.gz 'https://cache.ruby-lang.org/pub/ruby/4.0/ruby-4.0.3.tar.gz'
151151
- name: Download Jemalloc source
152152
run: curl -fsSL -o jemalloc-src.tar.bz2 'https://github.com/jemalloc/jemalloc/releases/download/3.6.0/jemalloc-3.6.0.tar.bz2'
153153
- name: Clone Rbenv source
@@ -181,7 +181,7 @@ jobs:
181181
./build-ruby \
182182
-n 'ubuntu-24.04' \
183183
-s "$(pwd)/ruby-src.tar.gz" \
184-
-v '3.4' \
184+
-v '4.0' \
185185
-o "$(pwd)/ruby-bin-ubuntu-24.04-normal.tar.gz" \
186186
-j 2
187187
@@ -190,27 +190,17 @@ jobs:
190190
./build-ruby \
191191
-n 'ubuntu-24.04' \
192192
-s "$(pwd)/ruby-src.tar.gz" \
193-
-v '3.4' \
193+
-v '4.0' \
194194
-o "$(pwd)/ruby-bin-ubuntu-24.04-jemalloc.tar.gz" \
195195
-m "$(pwd)/jemalloc-bin-ubuntu-24.04.tar.gz" \
196196
-j 2
197197
198-
- name: 'Build Ruby binaries [ubuntu-24.04/malloctrim]'
199-
run: |
200-
./build-ruby \
201-
-n 'ubuntu-24.04' \
202-
-s "$(pwd)/ruby-src.tar.gz" \
203-
-v '3.4' \
204-
-o "$(pwd)/ruby-bin-ubuntu-24.04-malloctrim.tar.gz" \
205-
-t \
206-
-j 2
207-
208198
- name: 'Build Ruby binaries [el-9/normal]'
209199
run: |
210200
./build-ruby \
211201
-n 'el-9' \
212202
-s "$(pwd)/ruby-src.tar.gz" \
213-
-v '3.4' \
203+
-v '4.0' \
214204
-o "$(pwd)/ruby-bin-el-9-normal.tar.gz" \
215205
-j 2
216206
@@ -219,21 +209,11 @@ jobs:
219209
./build-ruby \
220210
-n 'el-9' \
221211
-s "$(pwd)/ruby-src.tar.gz" \
222-
-v '3.4' \
212+
-v '4.0' \
223213
-o "$(pwd)/ruby-bin-el-9-jemalloc.tar.gz" \
224214
-m "$(pwd)/jemalloc-bin-el-9.tar.gz" \
225215
-j 2
226216
227-
- name: 'Build Ruby binaries [el-9/malloctrim]'
228-
run: |
229-
./build-ruby \
230-
-n 'el-9' \
231-
-s "$(pwd)/ruby-src.tar.gz" \
232-
-v '3.4' \
233-
-o "$(pwd)/ruby-bin-el-9-malloctrim.tar.gz" \
234-
-t \
235-
-j 2
236-
237217
- name: Create packages directory
238218
run: mkdir -p packages
239219

@@ -243,43 +223,29 @@ jobs:
243223
run: |
244224
./build-ruby-deb \
245225
-b "$(pwd)/ruby-bin-ubuntu-24.04-normal.tar.gz" \
246-
-o "$(pwd)/packages/fullstaq-ruby-3.4_7-ubuntu-24.04_amd64.deb" \
247-
-r '7'
226+
-o "$(pwd)/packages/fullstaq-ruby-4.0_2-ubuntu-24.04_amd64.deb" \
227+
-r '2'
248228
249229
- name: 'Build Ruby package [ubuntu-24.04/jemalloc]'
250230
run: |
251231
./build-ruby-deb \
252232
-b "$(pwd)/ruby-bin-ubuntu-24.04-jemalloc.tar.gz" \
253-
-o "$(pwd)/packages/fullstaq-ruby-3.4-jemalloc_7-ubuntu-24.04_amd64.deb" \
254-
-r '7'
255-
256-
- name: 'Build Ruby package [ubuntu-24.04/malloctrim]'
257-
run: |
258-
./build-ruby-deb \
259-
-b "$(pwd)/ruby-bin-ubuntu-24.04-malloctrim.tar.gz" \
260-
-o "$(pwd)/packages/fullstaq-ruby-3.4-malloctrim_7-ubuntu-24.04_amd64.deb" \
261-
-r '7'
233+
-o "$(pwd)/packages/fullstaq-ruby-4.0-jemalloc_2-ubuntu-24.04_amd64.deb" \
234+
-r '2'
262235
263236
- name: 'Build Ruby package [el-9/normal]'
264237
run: |
265238
./build-ruby-rpm \
266239
-b "$(pwd)/ruby-bin-el-9-normal.tar.gz" \
267-
-o "$(pwd)/packages/fullstaq-ruby-3.4-rev7-el9.x86_64.rpm" \
268-
-r '7'
240+
-o "$(pwd)/packages/fullstaq-ruby-4.0-rev2-el9.x86_64.rpm" \
241+
-r '2'
269242
270243
- name: 'Build Ruby package [el-9/jemalloc]'
271244
run: |
272245
./build-ruby-rpm \
273246
-b "$(pwd)/ruby-bin-el-9-jemalloc.tar.gz" \
274-
-o "$(pwd)/packages/fullstaq-ruby-3.4-jemalloc-rev7-el9.x86_64.rpm" \
275-
-r '7'
276-
277-
- name: 'Build Ruby package [el-9/malloctrim]'
278-
run: |
279-
./build-ruby-rpm \
280-
-b "$(pwd)/ruby-bin-el-9-malloctrim.tar.gz" \
281-
-o "$(pwd)/packages/fullstaq-ruby-3.4-malloctrim-rev7-el9.x86_64.rpm" \
282-
-r '7'
247+
-o "$(pwd)/packages/fullstaq-ruby-4.0-jemalloc-rev2-el9.x86_64.rpm" \
248+
-r '2'
283249
284250
### Build Rbenv packages ###
285251

@@ -336,10 +302,6 @@ jobs:
336302
variant: 'jemalloc'
337303
test_image: 'ubuntu:24.04'
338304
package_format: 'DEB'
339-
- distro: 'ubuntu-24.04'
340-
variant: 'malloctrim'
341-
test_image: 'ubuntu:24.04'
342-
package_format: 'DEB'
343305
- distro: 'el-9'
344306
variant: 'normal'
345307
test_image: 'rockylinux:9'
@@ -348,10 +310,6 @@ jobs:
348310
variant: 'jemalloc'
349311
test_image: 'rockylinux:9'
350312
package_format: 'RPM'
351-
- distro: 'el-9'
352-
variant: 'malloctrim'
353-
test_image: 'rockylinux:9'
354-
package_format: 'RPM'
355313
steps:
356314
- uses: actions/checkout@v4
357315

@@ -383,10 +341,10 @@ jobs:
383341
VARIANT_SUFFIX="-${VARIANT}"
384342
fi
385343
if [ "$FORMAT" = "DEB" ]; then
386-
FILENAME="fullstaq-ruby-3.4${VARIANT_SUFFIX}_7-${DISTRO}_amd64.deb"
344+
FILENAME="fullstaq-ruby-4.0${VARIANT_SUFFIX}_2-${DISTRO}_amd64.deb"
387345
else
388346
SANITIZED_DISTRO=$(echo "$DISTRO" | tr -d '-')
389-
FILENAME="fullstaq-ruby-3.4${VARIANT_SUFFIX}-rev7-${SANITIZED_DISTRO}.x86_64.rpm"
347+
FILENAME="fullstaq-ruby-4.0${VARIANT_SUFFIX}-rev2-${SANITIZED_DISTRO}.x86_64.rpm"
390348
fi
391349
echo "filename=${FILENAME}" >> "$GITHUB_OUTPUT"
392350

.github/workflows/ci-cd-contributor.yml.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ jobs:
139139
### Build Ruby binaries ###
140140

141141
<%- contributor_distributions.each do |distro| -%>
142-
<%- variants.each do |variant| -%>
142+
<%- variants_for_ruby_version(rpv).each do |variant| -%>
143143
- name: 'Build Ruby binaries [<%= distro[:name] %>/<%= variant[:name] %>]'
144144
run: |
145145
./build-ruby \
@@ -162,7 +162,7 @@ jobs:
162162
### Build Ruby packages ###
163163

164164
<%- contributor_distributions.each do |distro| -%>
165-
<%- variants.each do |variant| -%>
165+
<%- variants_for_ruby_version(rpv).each do |variant| -%>
166166
<%- pkg_basename = ruby_package_basename(rpv, distro, variant) -%>
167167
- name: 'Build Ruby package [<%= distro[:name] %>/<%= variant[:name] %>]'
168168
run: |
@@ -225,7 +225,7 @@ jobs:
225225
matrix:
226226
include:
227227
<%- contributor_distributions.each do |distro| -%>
228-
<%- variants.each do |variant| -%>
228+
<%- variants_for_ruby_version(rpv).each do |variant| -%>
229229
- distro: '<%= distro[:name] %>'
230230
variant: '<%= variant[:name] %>'
231231
test_image: '<%= distro[:test_image] %>'

0 commit comments

Comments
 (0)