UI: replication status: show if any errors during run

Author: joonas-fi

frontend/pages/VolumesAndMountsPage.tsx

@@ -716,6 +716,7 @@ export default class VolumesAndMountsPage extends React.Component<
 				<thead>
 					<tr>
 						<th>Volume</th>
+						<th></th>
 						<th>Progress</th>
 					</tr>
 				</thead>
@@ -726,6 +727,11 @@ export default class VolumesAndMountsPage extends React.Component<
 						return (
 							<tr key={status.VolumeId}>
 								<td>{volume.Label}</td>
+								<td>
+									{status.Error ? (
+										<Glyphicon icon="exclamation-sign" title={status.Error} />
+									) : null}
+								</td>
 								<td>
 									{status.Progress === 100 ? (
 										'Realtime'

pkg/stoserver/restapi.go

@@ -29,6 +29,7 @@ import (
 	"github.com/function61/gokit/logex"
 	"github.com/function61/varasto/pkg/blorm"
 	"github.com/function61/varasto/pkg/duration"
+	"github.com/function61/varasto/pkg/gokitbp"
 	"github.com/function61/varasto/pkg/scheduler"
 	"github.com/function61/varasto/pkg/stateresolver"
 	"github.com/function61/varasto/pkg/stoserver/stodb"
@@ -854,6 +855,13 @@ func (h *handlers) GetReplicationStatuses(rctx *httpauth.RequestContext, w http.
 		statuses = append(statuses, stoservertypes.ReplicationStatus{
 			VolumeId: volID,
 			Progress: controller.Progress(),
+			Error: func() *string {
+				if err := controller.Error(); err != nil {
+					return gokitbp.Pointer(err.Error())
+				} else {
+					return nil
+				}
+			}(),
 		})
 	}
 

pkg/stoserver/stoservertypes/types.json

@@ -260,6 +260,7 @@
 			"name": "ReplicationStatus",
 			"type": {"_": "object", "fields": {
 				"VolumeId": {"_": "integer"},
+				"Error": {"_": "string", "nullable": true},
 				"Progress": {"_": "integer"}
 			}}
 		},