Skip to content

Commit 968a11c

Browse files
committed
directory rich view: bugfix: show metadata even for directories that don't have it
this fixes bug where some directory entries were just plain hidden bonus: - wordsmithing: `Id` -> `ID`
1 parent 59c526c commit 968a11c

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

frontend/component/metadata.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,12 @@ interface MetadataKeyValue {
3434
}
3535

3636
interface MetadataPanelProps {
37-
showTitle?: boolean; // shows title and publication date
38-
showDetails?: boolean; // shows summary, publication date and external links
37+
/** shows title and publication date */
38+
showTitle?: boolean;
39+
/** shows summary, publication date and external links */
40+
showDetails?: boolean;
41+
/** if panel would be mostly without content, don't show it */
42+
skipRenderingIfNoMetadata?: boolean;
3943
imageLinksToCollection?: boolean;
4044
collWithMeta: CollectionSubsetWithMeta;
4145
}
@@ -48,7 +52,8 @@ export class MetadataPanel extends React.Component<MetadataPanelProps, {}> {
4852

4953
const metadata = metadataKvsToKv(coll.Metadata);
5054

51-
if (Object.keys(metadata).length === 0) {
55+
const noMetadata = Object.keys(metadata).length === 0;
56+
if (noMetadata && this.props.skipRenderingIfNoMetadata) {
5257
return null;
5358
}
5459

frontend/pages/BrowsePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ export default class BrowsePage extends React.Component<BrowsePageProps, BrowseP
421421
<table className={tableClassStripedHover}>
422422
<tbody>
423423
<tr>
424-
<th>Id</th>
424+
<th>ID</th>
425425
<td>
426426
{dir.Id}
427427
<span className="margin-left">

frontend/pages/CollectionPage.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ export default class CollectionPage extends React.Component<
213213
<MetadataPanel
214214
collWithMeta={collOutput.CollectionWithMeta}
215215
showDetails={true}
216+
skipRenderingIfNoMetadata={true}
216217
/>
217218

218219
{(this.props.view === ViewType.Auto && haveAnyThumbnails) ||
@@ -234,7 +235,7 @@ export default class CollectionPage extends React.Component<
234235
<table className={tableClassStripedHover}>
235236
<tbody>
236237
<tr>
237-
<th>Id</th>
238+
<th>ID</th>
238239
<td>
239240
{coll.Id}
240241

0 commit comments

Comments
 (0)