apps/box: replace Loyal Agent tab with top-level Blox AI tab

The bottom-tab "Loyal Agent" pointed at ChatAIScreen — a freeform
chat surface that posted to the container's chat endpoint with a
hardcoded 'deepseek-chat' model name (cosmetic only since the
container now runs Qwen) and short-circuited iOS users with
"iOS is not currently supported." Meanwhile the new structured Blox
AI flow (the marquee feature: verdict + tool-call + approve) was
buried under Settings then Diagnostics, hidden from anyone who didn't
know to look there.

Promote Diagnostics to a top-level tab and retire the freeform-chat
surface entirely:

- navigationConfig.ts:
  - Add Routes.DiagnosticsTab = 'DiagnosticsTab' (follows *Tab
    convention for top-level tabs).
  - Remove Routes.ChatAI, Routes.ChatAITab, Routes.Diagnostics
    (the SettingsStack child route, now unreachable since the tab
    is the only entry).
  - Add to MainTabsParamList, remove from RootStackParamList and
    SettingsStackParamList.
- MainTabs.navigator.tsx:
  - Replace the ChatAITab tab block with DiagnosticsTab pointing
    at DiagnosticsScreen, label "Blox AI", icon FxSearchIcon
    (magnifying glass — best fit for "diagnose / investigate" in the
    existing palette).
  - Drop the ChatAIScreen import and FxScanCodeIcon import.
  - Remove the now-redundant SettingsStack.Screen for Diagnostics.
- Diagnostics.test.tsx:
  - Update the route-registered assertion from Routes.Diagnostics
    (== 'Diagnostics') to Routes.DiagnosticsTab (== 'DiagnosticsTab').
- Delete ChatAI.screen.tsx (434 lines, fully obsolete).

What this does NOT remove:
- The container's chat endpoint stays (kept per the plan as
  backward-compat for any future freeform-chat surface). If we ever
  re-add freeform chat, it should be cross-platform (the deleted
  ChatAIScreen was Android-only) and not hardcode an old model name.

Test posture:
- 23 Diagnostics jest tests pass (including the updated route-id check).
- A pre-existing ApprovalModal.test.tsx module-resolve failure for
  @functionland/component-library is unrelated (jest moduleNameMapper
  infra issue; predates this work; ApprovalModal not touched here).
- Pre-existing tsc jest-typedef errors in components.test.tsx
  also predate this work; not affected by these edits.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: ehsan6sha

apps/box/src/navigation/MainTabs.navigator.tsx

@@ -4,14 +4,13 @@ import {
   FxBottomSheetModalMethods,
   FxArrowUpIcon,
   useFxTheme,
-  FxScanCodeIcon,
+  FxSearchIcon,
 } from '@functionland/component-library';
 import { createNativeStackNavigator } from '@react-navigation/native-stack';
 import { BloxScreen } from '../screens/Blox/Blox.screen';
 import { PluginScreen } from '../screens/Plugin.screen';
 import { DevicesScreen } from '../screens/Devices.screen';
 import { UsersScreen } from '../screens/Users/Users.screen';
-import ChatAIScreen from '../screens/ChatAI.screen';
 import {
   BloxIcon,
   UserIcon,
@@ -268,12 +267,12 @@ export const MainTabsNavigator = () => {
           })}
         />
         <MainTabs.Screen
-          name={Routes.ChatAITab}
-          component={ChatAIScreen}
+          name={Routes.DiagnosticsTab}
+          component={DiagnosticsScreen}
           options={{
             // eslint-disable-next-line react/no-unstable-nested-components
-            tabBarIcon: ({ color }) => <FxScanCodeIcon fill={color} />,
-            tabBarLabel: 'Loyal Agent',
+            tabBarIcon: ({ color }) => <FxSearchIcon fill={color} />,
+            tabBarLabel: 'Blox AI',
           }}
         />
         <MainTabs.Screen
@@ -349,10 +348,6 @@ const SettingsNavigator = () => {
         name={Routes.AutoPinPairing}
         component={AutoPinPairingScreen}
       />
-      <SettingsStack.Screen
-        name={Routes.Diagnostics}
-        component={DiagnosticsScreen}
-      />
 
       <SettingsStack.Screen
         options={() => ({

apps/box/src/navigation/navigationConfig.ts

@@ -11,7 +11,6 @@ export enum Routes {
   MainTabs = 'MainTabs',
   Hub = 'Hub',
   Plugin = 'Plugin',
-  ChatAI = 'ChatAI',
 
   // Initial Setup
   Welcome = 'Welcome',
@@ -31,7 +30,7 @@ export enum Routes {
   PluginTab = 'PluginTab',
   DevicesTab = 'DevicesTab',
   SettingsTab = 'SettingsTab',
-  ChatAITab = 'ChatAITab',
+  DiagnosticsTab = 'DiagnosticsTab',
 
   // Blox Manager
   BloxManager = 'BloxManager',
@@ -50,7 +49,6 @@ export enum Routes {
   BloxLogs = 'BloxLogs',
   BluetoothCommands = 'BluetoothCommands',
   AutoPinPairing = 'AutoPinPairing',
-  Diagnostics = 'Diagnostics',
 
   // Component Gallery
   Avatars = 'Avatars',
@@ -72,7 +70,6 @@ export type RootStackParamList = {
   [Routes.MainTabs]: NavigatorScreenParams<MainTabsParamList>;
   [Routes.Hub]: undefined;
   [Routes.Plugin]: undefined;
-  [Routes.ChatAI]: undefined;
   [Routes.BloxManager]: undefined;
 };
 
@@ -84,7 +81,7 @@ export type MainTabsParamList = {
   [Routes.DevicesTab]: undefined;
   [Routes.SettingsTab]: NavigatorScreenParams<SettingsStackParamList>;
   [Routes.InitialSetup]: undefined;
-  [Routes.ChatAITab]: undefined;
+  [Routes.DiagnosticsTab]: undefined;
 };
 
 export type SettingsStackParamList = {
@@ -110,7 +107,6 @@ export type SettingsStackParamList = {
     endpoint?: string;
     returnUrl?: string;
   };
-  [Routes.Diagnostics]: undefined;
   [Routes.ComponentGallery]: NavigatorScreenParams<ComponentGalleryStackParamList>;
 };