warning on old version

Author: gauron99

.github/workflows/test-action.yml

@@ -16,7 +16,7 @@ jobs:
   test-custom-version:
     runs-on: ubuntu-latest
     env:
-      TEST_VERSION: '1.19.0'
+      TEST_VERSION: '1.18.0'
       VERSION_OFFSET: 27  # internal version = minor + offset (v1.19 → v0.46)
     steps:
       - uses: actions/checkout@v4

index.js

@@ -35,18 +35,6 @@ function getOsBinName() {
     }
 }
 
-function resolveFullPathBin() {
-    const destination = core.getInput('destination') || process.cwd();
-    let bin = core.getInput('name') || 'func';
-    if (process.env.RUNNER_OS === 'Windows' && !bin.endsWith('.exe')) {
-        bin += '.exe';
-    }
-    if (!fs.existsSync(destination)) {
-        fs.mkdirSync(destination, { recursive: true });
-    }
-    return path.resolve(destination, bin);
-}
-
 // Normalizes version to release tag format: knative-vX.Y.Z
 // Ex.: '1.16' or 'v1.16' will return 'knative-v1.16.0'
 function smartVersionUpdate(version) {
@@ -61,6 +49,37 @@ function smartVersionUpdate(version) {
     return `${knprefix}${prefix}${match.groups.major}.${match.groups.minor}.${patch}`;
 }
 
+function resolveVersion() {
+    if (core.getInput('binarySource') !== "") return null;
+    const versionInput = core.getInput('version') || DEFAULT_FUNC_VERSION;
+    if (versionInput.toLowerCase().trim() === DEFAULT_FUNC_VERSION) return null;
+    return smartVersionUpdate(versionInput);
+}
+
+// Resolve download url based on given input
+// binName: name of func binary when it is to be constructed for full URL
+// (when not using binarySource)
+function resolveDownloadUrl(version, binName) {
+    const binarySource = core.getInput('binarySource');
+    if (binarySource !== "") {
+        core.info(`Using custom binary source: ${binarySource}`);
+        return binarySource;
+    }
+
+    if (!version) {
+        core.info("Using latest version...");
+        return buildUrlString(DEFAULT_FUNC_VERSION);
+    }
+    core.info(`Using specific version ${version}`);
+    return buildUrlString(version);
+
+    function buildUrlString(version) {
+        return version === DEFAULT_FUNC_VERSION
+            ? `${DEFAULT_LATEST_BINARY_SOURCE}/${binName}`
+            : `${DEFAULT_BINARY_SOURCE}/${version}/${binName}`;
+    }
+}
+
 // Downloads binary from release URL and makes it executable
 async function downloadFuncBinary(url, binPath) {
     core.info(`Downloading from: ${url}`);
@@ -76,6 +95,18 @@ async function downloadFuncBinary(url, binPath) {
     }
 }
 
+function resolveFullPathBin() {
+    const destination = core.getInput('destination') || process.cwd();
+    let bin = core.getInput('name') || 'func';
+    if (process.env.RUNNER_OS === 'Windows' && !bin.endsWith('.exe')) {
+        bin += '.exe';
+    }
+    if (!fs.existsSync(destination)) {
+        fs.mkdirSync(destination, { recursive: true });
+    }
+    return path.resolve(destination, bin);
+}
+
 // Adds binary directory to PATH for current and subsequent steps
 function addBinToPath(binPath) {
     const dir = path.dirname(binPath);
@@ -87,29 +118,45 @@ function addBinToPath(binPath) {
     }
 }
 
-// Resolve download url based on given input
-// binName: name of func binary when it is to be constructed for full URL
-// (when not using binarySource)
-function resolveDownloadUrl(binName) {
-    const binarySource = core.getInput('binarySource');
-    if (binarySource !== "") {
-        core.info(`Using custom binary source: ${binarySource}`);
-        return binarySource;
-    }
+// Returns difference of minor versions between 'latest' and 'version'
+// subtracts 'version' from 'latest' (returns negative if 'version' is ahead)
+// If minor version cannot be extracted on either number - return 0
+function versionDiff(latest, version) {
+    const extractMinor = (v) => {
+        const match = v.match(/(\d+)\.(\d+)/);
+        return match ? parseInt(match[2], 10) : null;
+    };
+
+    const latestMinor = extractMinor(latest);
+    const versionMinor = extractMinor(version);
+    if (latestMinor === null || versionMinor === null) {
+        return 0;
+    }
+    return latestMinor - versionMinor;
+}
 
-    const versionInput = core.getInput('version') || DEFAULT_FUNC_VERSION;
-    if (versionInput.toLowerCase().trim() === DEFAULT_FUNC_VERSION) {
-        core.info("Using latest version...");
-        return buildUrlString(DEFAULT_FUNC_VERSION);
-    }
-    const version = smartVersionUpdate(versionInput);
-    core.info(`Using specific version ${version}`);
-    return buildUrlString(version);
+// Warn if version requested is more than 2 versions behind latest (>= 3)
+// This function does NOT error
+async function warnStaleVersion(version) {
+    const API_LATEST = 'https://api.github.com/repos/knative/func/releases/latest';
+    const THRESHOLD = 3;
 
-    function buildUrlString(version) {
-        return version === DEFAULT_FUNC_VERSION
-            ? `${DEFAULT_LATEST_BINARY_SOURCE}/${binName}`
-            : `${DEFAULT_BINARY_SOURCE}/${version}/${binName}`;
+    try {
+        const response = await fetch(API_LATEST);
+        if (!response.ok) {
+            throw new Error(`failed to fetch latest version: ${response.status}`);
+        }
+
+        const data = await response.json();
+        const latest = data.tag_name;
+        const diff = versionDiff(latest, version);
+        if (diff >= THRESHOLD) {
+            core.warning(
+                `You are using func ${version}, which is ${diff} versions behind the latest (${latest}). Upgrading is recommended.`
+            );
+        }
+    } catch (error) {
+        core.debug(`Skipping stale version check: ${error.message}`);
     }
 }
 
@@ -122,9 +169,17 @@ async function run() {
         return;
     }
 
+    let version;
+    try {
+        version = resolveVersion();
+    } catch (error) {
+        core.setFailed(error.message);
+        return;
+    }
+
     let url;
     try {
-        url = resolveDownloadUrl(osBinName);
+        url = resolveDownloadUrl(version, osBinName);
     } catch (error) {
         core.setFailed(`Failed to resolve url: ${error.message}`);
         return;
@@ -152,6 +207,11 @@ async function run() {
         return;
     }
 
+    // Warn if using an old version (only for specific versions, not binarySource or latest)
+    if (version) {
+        await warnStaleVersion(version);
+    }
+
     try {
         await exec.exec(fullPathBin, ['version']);
     } catch (error) {