fix: propagate errors from known_hosts setup instead of silently ignoring#155
Merged
creydr merged 1 commit intoMay 20, 2026
Merged
Conversation
…ring them When a user provides known_hosts data in the auth secret, errors during temp file creation, writing, or callback setup were silently swallowed, causing silent fallback to no host key verification. Now these errors are returned so the operator knows when known_hosts setup fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if err == nilchain ingetSSHClientOptionswith proper error returns when known_hosts temp file creation, writing, or callback setup failsPreviously, if a user provided
known_hostsdata but the setup failed (e.g. temp file write error), the error was silently swallowed and the connection fell back to insecure mode without any indication.