fix: address second round of PR #26 review comments

Remove tooltip from refresh button. Drop useCallback from
onRefresh. Extract loadFunctions as a standalone async
function called directly from onRefresh and from useEffect
for initial load, eliminating the refreshKey state.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>

Author: matejvasek

src/views/FunctionsListPage.tsx

@@ -13,10 +13,9 @@ import {
   Toolbar,
   ToolbarContent,
   ToolbarItem,
-  Tooltip,
 } from '@patternfly/react-core';
 import { SyncAltIcon } from '@patternfly/react-icons';
-import { useCallback, useContext, useEffect, useMemo, useState } from 'react';
+import { useContext, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { Link, useNavigate } from 'react-router-dom-v5-compat';
 import { FunctionsEmptyState } from '../components/EmptyState';
@@ -28,7 +27,6 @@ import {
 } from '../context/ForgeConnectionProvider';
 import { useClusterService } from '../services/cluster/useClusterService';
 import { useSourceControlService } from '../services/source-control/useSourceControlService';
-import { RepoMetadata } from '../services/types';
 import { errorMessage, parseNamespaceAndRuntime } from '../utils/utils';
 
 export default function FunctionsListPage() {
@@ -87,17 +85,15 @@ function FunctionsListPageContent() {
                 </ToolbarItem>
                 <ToolbarItem variant="separator" />
                 <ToolbarItem>
-                  <Tooltip content={t('Refresh')}>
-                    <Button
-                      variant="plain"
-                      aria-label={t('Refresh')}
-                      onClick={onRefresh}
-                      isLoading={refreshing}
-                      spinnerAriaLabel={t('Refreshing')}
-                      isDisabled={refreshing}
-                      icon={<SyncAltIcon />}
-                    />
-                  </Tooltip>
+                  <Button
+                    variant="plain"
+                    aria-label={t('Refresh')}
+                    onClick={onRefresh}
+                    isLoading={refreshing}
+                    spinnerAriaLabel={t('Refreshing')}
+                    isDisabled={refreshing}
+                    icon={<SyncAltIcon />}
+                  />
                 </ToolbarItem>
               </ToolbarContent>
             </Toolbar>
@@ -127,13 +123,7 @@ function useFunctionListPage(): {
   const [prevConnectionId, setPrevConnectionId] = useState(connectionId);
 
   const [error, setError] = useState<string>('');
-  const [refreshKey, setRefreshKey] = useState(0);
   const [refreshing, setRefreshing] = useState(false);
-  const onRefresh = useCallback(() => {
-    if (!isConnectedToForge) return;
-    setRefreshing(true);
-    setRefreshKey((k) => k + 1);
-  }, [isConnectedToForge]);
 
   // Reset state when connection changes (initial connect or user switch)
   if (connectionId !== prevConnectionId) {
@@ -143,44 +133,38 @@ function useFunctionListPage(): {
     setReposLoaded(false);
   }
 
-  useEffect(() => {
-    if (!isConnectedToForge) return;
-
-    let ignore = false;
-
-    async function loadFunctionTableItems() {
-      let repos: RepoMetadata[];
-      let items: FunctionTableItem[];
-      try {
-        repos = await sourceControl.listFunctionRepos();
-        items = await Promise.all(
-          repos.map(async (repo) => {
-            const funcYaml = await sourceControl.fetchFileContent(repo, 'func.yaml');
-            const { namespace, runtime } = parseNamespaceAndRuntime(funcYaml);
-            return newItem(repo.name, namespace, runtime);
-          }),
-        );
-      } catch (err) {
-        if (!ignore) {
-          setReposLoaded(true);
-          setRefreshing(false);
-          setError(errorMessage(err));
-        }
-        return;
-      }
-      if (ignore) return;
-
+  async function loadFunctions() {
+    try {
+      const repos = await sourceControl.listFunctionRepos();
+      const items = await Promise.all(
+        repos.map(async (repo) => {
+          const funcYaml = await sourceControl.fetchFileContent(repo, 'func.yaml');
+          const { namespace, runtime } = parseNamespaceAndRuntime(funcYaml);
+          return newItem(repo.name, namespace, runtime);
+        }),
+      );
       setFunctionItems(items);
       setReposLoaded(true);
       setRefreshing(false);
       setError('');
+    } catch (err) {
+      setReposLoaded(true);
+      setRefreshing(false);
+      setError(errorMessage(err));
     }
+  }
 
-    loadFunctionTableItems();
-    return () => {
-      ignore = true;
-    };
-  }, [sourceControl, isConnectedToForge, connectionId, refreshKey]);
+  function onRefresh() {
+    if (!isConnectedToForge) return;
+    setRefreshing(true);
+    loadFunctions();
+  }
+
+  useEffect(() => {
+    if (!isConnectedToForge) return;
+    loadFunctions();
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [sourceControl, isConnectedToForge, connectionId]);
 
   const functionNames = useMemo(() => functionItems.map((item) => item.name), [functionItems]);