|
45 | 45 | "Delete action uses SDK useDeleteModal with custom message and Undeploy button text", |
46 | 46 | "Empty state renders when no functions exist, spinner while loading" |
47 | 47 | ], |
48 | | - "passes": false |
| 48 | + "passes": true |
49 | 49 | }, |
50 | 50 | { |
51 | 51 | "category": "technical", |
|
71 | 71 | }, |
72 | 72 | { |
73 | 73 | "category": "technical", |
74 | | - "description": "Claude Code sandbox: isolated VM environment for autonomous agent development", |
| 74 | + "description": "PR #5 review cleanup: consolidate duplicate GitHub services, fix naming conventions, extract hooks per architecture guidelines", |
75 | 75 | "steps": [ |
76 | | - "Vagrant VM with Fedora (matching host OS) provisioned", |
77 | | - "Project directory mounted into VM", |
78 | | - "Full write permissions enabled for agent", |
79 | | - "Git worktree creation works inside VM", |
80 | | - "Agent can run full startup sequence autonomously in VM", |
81 | | - "VM isolation ensures no leakage to host workstation" |
| 76 | + "Merge src/services/github/ into src/services/source-control/, combine OctokitGitHubService push logic into GithubService, remove src/services/github/ directory entirely", |
| 77 | + "Rename GitHubService interface to SourceControlService and add push method to the existing SourceControlService interface (rename pushFiles to push per design doc)", |
| 78 | + "Rename useGitHubService hook to useSourceControlService", |
| 79 | + "Rename BackendFunctionService.ts to FunctionBackendService.ts", |
| 80 | + "Remove duplicate @octokit/rest from devDependencies in package.json (keep only the entry under dependencies)", |
| 81 | + "Extract useFunctionCreatePage hook from FunctionCreatePage — move service calls into useEffect (both FunctionService and SourceControlService call external APIs), keep the component rendering-only", |
| 82 | + "Extract useCreateFunctionForm hook from CreateFunctionForm — consolidate individual useState calls into a single fields state object with a setField(key, value) helper, derive isValid from fields, remove handleSubmit (call onSubmit(fields) directly)", |
| 83 | + "Update design doc (2026-03-16-faas-poc-design.md) to reflect all renames and new method signatures" |
82 | 84 | ], |
83 | | - "passes": false |
| 85 | + "passes": true |
| 86 | + }, |
| 87 | + { |
| 88 | + "category": "functional", |
| 89 | + "description": "Route rename and nav restructure: change /functions to /faas, flatten dev nav, add admin nav under Workloads", |
| 90 | + "steps": [ |
| 91 | + "Rename all routes from /functions/* to /faas/* (list, create, edit)", |
| 92 | + "Developer perspective: replace section+href with a single top-level console.navigation/href 'FaaS' pointing to /faas", |
| 93 | + "Admin perspective: add console.navigation/separator and console.navigation/href 'FaaS' under section 'workloads' at the bottom (using insertAfter)", |
| 94 | + "Update all internal links and navigation calls (e.g., Create button href, form cancel, post-create redirect)", |
| 95 | + "Update tests to use /faas routes" |
| 96 | + ], |
| 97 | + "passes": true |
84 | 98 | }, |
85 | 99 | { |
86 | 100 | "category": "functional", |
|
110 | 124 | "Deployed functions without a matching repo still appear in the table with available cluster data (name, namespace, status, replicas, url)" |
111 | 125 | ], |
112 | 126 | "passes": false |
113 | | - }, |
114 | | - { |
115 | | - "category": "technical", |
116 | | - "description": "PR #5 review cleanup: consolidate duplicate GitHub services, fix naming conventions, extract hooks per architecture guidelines", |
117 | | - "steps": [ |
118 | | - "Merge src/services/github/ into src/services/source-control/, combine OctokitGitHubService push logic into GithubService, remove src/services/github/ directory entirely", |
119 | | - "Rename GitHubService interface to SourceControlService and add push method to the existing SourceControlService interface (rename pushFiles to push per design doc)", |
120 | | - "Rename useGitHubService hook to useSourceControlService", |
121 | | - "Rename BackendFunctionService.ts to FunctionBackendService.ts", |
122 | | - "Remove duplicate @octokit/rest from devDependencies in package.json (keep only the entry under dependencies)", |
123 | | - "Extract useFunctionCreatePage hook from FunctionCreatePage — move service calls into useEffect (both FunctionService and SourceControlService call external APIs), keep the component rendering-only", |
124 | | - "Extract useCreateFunctionForm hook from CreateFunctionForm — consolidate individual useState calls into a single fields state object with a setField(key, value) helper, derive isValid from fields, remove handleSubmit (call onSubmit(fields) directly)", |
125 | | - "Update design doc (2026-03-16-faas-poc-design.md) to reflect all renames and new method signatures" |
126 | | - ], |
127 | | - "passes": true |
128 | 127 | } |
129 | 128 | ] |
0 commit comments