refactor: consolidate GitHub services

Merged src/services/github/ into src/services/source-control/. The
duplicate OctokitGitHubService push logic now lives in GithubService
behind a unified SourceControlService interface with a new push()
method. Removed the src/services/github/ directory entirely.

Renamed BackendFunctionService to FunctionBackendService and
useSourceControl to useSourceControlService to follow naming
conventions. Removed duplicate @octokit/rest from devDependencies.

Extracted useCreateFunctionForm hook inside CreateFunctionForm and
useFunctionCreatePage hook inside FunctionCreatePage per architecture
guidelines. Removed PAT field from create form (PAT management
deferred to upcoming session-wide PAT feature).

Updated design doc and workflow with received PR reviews section.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: twoGiants

docs/STYLEGUIDE.md

@@ -18,6 +18,10 @@
 - **No `console.log`**: Use structured approach if logging needed.
 - **Naming**: `use*` for hooks, `*Service` for services, PascalCase for components/types.
 
+## Documentation
+
+- **No em dashes (`—`)**. Use commas, periods, or parentheses instead.
+
 ## OCP Plugin Styling Constraints
 
 The `.stylelintrc.yaml` enforces strict rules to prevent breaking the OpenShift Console:

docs/WORKFLOW.md

@@ -21,10 +21,13 @@ After [Startup Sequence](#startup-sequence), work through the picked feature:
 3. **Implement** — using `/executing-plans` skill
 4. **Review** — code review using `/requesting-code-review` skill, fix found issues
 5. **Manual Test** — use browser automation and validate it works in the browser
-6. **Complete** — flip `passes` to `true` in [`docs/features.json`](references/features-json-readme.md), update [`docs/claude-progress.txt`](references/claude-progress-readme.md), commit
+6. **Complete** — flip `passes` to `true` in [`docs/features.json`](references/features-json-readme.md), update [`docs/claude-progress.txt`](references/claude-progress-readme.md), move plan to `docs/plans/completed/`, commit
 7. **PR** — push branch, open PR per [Pull Requests](#pull-requests) convention
-8. Move plan to `docs/plans/completed/`
-9. Stop, wait for user command
+8. Stop — wait for PR review. Rework per [Received PR Reviews](#received-pr-reviews) when asked.
+
+## Received PR Reviews
+
+For each comment: read the full text and its diff hunk context, make the fix, then re-read the comment and verify your change actually matches what was asked (placement, naming, scope — not just compilation). Reply in the thread stating what changed.
 
 ## Branching
 
@@ -38,6 +41,8 @@ Open PRs via `gh pr create` using the template at `.github/pull_request_template
 
 Types are the same as [conventional commits](references/commit-message-guide.md#conventional-commits) but capitalized.
 
+No em dashes (`—`) in PR titles or descriptions. Use commas, periods, or parentheses instead.
+
 ## Session Rules
 
 - One feature at a time

docs/claude-progress.txt

@@ -1,6 +1,25 @@
 # Claude Progress Log
 # Newest entries first. Agents: append your entry at the top after the header.
 
+---
+## 2026-04-16 | Session: PR #5 review cleanup
+Worked on: Consolidate duplicate GitHub services, fix naming conventions, extract hooks per architecture guidelines
+Completed:
+- Merged src/services/github/ push logic into src/services/source-control/GithubService
+- Added push() method to SourceControlService interface
+- Deleted src/services/github/ directory entirely
+- Renamed BackendFunctionService → FunctionBackendService
+- Renamed useSourceControl → useSourceControlService
+- Extracted useCreateFunctionForm hook from CreateFunctionForm (single fields state object + setField helper)
+- Extracted useFunctionCreatePage hook from FunctionCreatePage (rendering-only component)
+- Removed duplicate @octokit/rest from devDependencies
+- Updated design doc with all renames and FileEntry[] signatures
+- Code review: added missing error alert test, fixed quote style, cleaned up GeneratedFiles refs
+- Added missing feature entries to features.json (PAT Avatar, namespace listing, PR #5 cleanup)
+- 10 suites, 41 tests, all passing
+Left off: Branch ready for PR. Manual browser test skipped (no browser in sandbox).
+Blockers: None
+
 ---
 ## 2026-04-02 | Session: Function Create Page
 Worked on: Full-stack Function Create Page feature (plan 003)

docs/design/2026-03-16-faas-poc-design.md

@@ -20,7 +20,7 @@ flowchart TB
     subgraph UI [Browser - React + PatternFly 6]
         VIEWS[Views: List / Create / Editor]
         FS[useFunctionService hook]
-        SCS[useSourceControl hook]
+        SCS[useSourceControlService hook]
         CS[useClusterService hook]
     end
 
@@ -117,15 +117,15 @@ func-console/
 │
 ├── src/
 │   ├── services/                 # interfaces + implementations
-│   │   ├── types.ts              # FunctionConfig, GeneratedFiles, etc.
+│   │   ├── types.ts              # FunctionConfig, FileEntry, RepoInfo, etc.
 │   │   ├── function/
 │   │   │   ├── FunctionService.ts          # TypeScript interface
 │   │   │   ├── useFunctionService.ts       # hook returning singleton
-│   │   │   └── FunctionService.github.ts   # PoC implementation
+│   │   │   └── FunctionBackendService.ts    # backend proxy implementation
 │   │   ├── source-control/
 │   │   │   ├── SourceControlService.ts     # TypeScript interface
-│   │   │   ├── useSourceControl.ts         # hook returning singleton
-│   │   │   └── SourceControlService.github.ts
+│   │   │   ├── useSourceControlService.ts  # hook returning singleton
+│   │   │   └── GithubService.ts            # Octokit implementation (list, fetch, push)
 │   │   └── cluster/
 │   │       ├── ClusterService.ts           # TypeScript interface
 │   │       └── useClusterService.ts        # hook wrapping OCP SDK hooks
@@ -174,7 +174,6 @@ interface FileEntry {
   type: 'blob';
 }
 
-type GeneratedFiles = Map<string, FileEntry>;  // filepath → content
 ```
 
 ### FunctionService
@@ -195,8 +194,7 @@ interface FunctionService {
 }
 ```
 
-- `generateFunction` → func.yaml, handler code, package files, .gitignore, tests
-- `generateWorkflow` → .github/workflows/func-deploy.yaml
+- `generateFunction` → func.yaml, handler code, package files, .gitignore, tests, github workflow
 - Output consumed by TreeView+CodeEditor (display) and Octokit (push)
 
 #### Error Handling
@@ -224,8 +222,8 @@ interface SourceControlService {
   isAuthenticated(): boolean;
   createRepo(name: string): Promise<RepoInfo>;
   listFunctionRepos(): Promise<RepoInfo[]>;
-  push(repo: RepoInfo, files: GeneratedFiles, message: string): Promise<void>;
-  fetch(repo: RepoInfo): Promise<GeneratedFiles>;
+  push(repo: RepoInfo, files: FileEntry[], message: string): Promise<void>;
+  fetch(repo: RepoInfo): Promise<FileEntry[]>;
   createSecret(repo: RepoInfo, name: string, value: string): Promise<void>;
   createVariable(repo: RepoInfo, name: string, value: string): Promise<void>;
 }
@@ -338,7 +336,7 @@ The Functions List Page needs data from **both** services. A dedicated merging h
 ```tsx
 // useFunctionsList: merges GitHub repos (source of truth) with cluster status
 export function useFunctionsList(): { functions: FunctionListItem[]; loaded: boolean } {
-  const { repos, loaded: reposLoaded } = useSourceControl();
+  const { repos, loaded: reposLoaded } = useSourceControlService();
   const { functions: deployments, loaded: deploymentsLoaded } = useClusterService();
 
   const functions = mergeFunctionData(repos, deployments);
@@ -435,7 +433,7 @@ Form validation errors shown inline. Background errors (repo creation, push) sur
 
 ### Functions Edit Page
 
-PatternFly TreeView sidebar + SDK CodeEditor. Tree built from `GeneratedFiles` map keys split on `/`. Shows full repo contents.
+PatternFly TreeView sidebar + SDK CodeEditor. Tree built from `FileEntry[]` paths split on `/`. Shows full repo contents.
 
 **Actions:**
 
@@ -447,7 +445,7 @@ PatternFly TreeView sidebar + SDK CodeEditor. Tree built from `GeneratedFiles` m
 | Component | Purpose |
 |-----------|---------|
 | `CodeEditor` | Monaco-based code editor (lazy loaded) |
-| PatternFly TreeView | File tree sidebar built from `GeneratedFiles` map keys |
+| PatternFly TreeView | File tree sidebar built from `FileEntry[]` paths |
 | `ErrorBoundaryFallbackPage` | Catch unexpected errors |
 
 #### Error Handling

docs/features.json

@@ -81,5 +81,49 @@
       "VM isolation ensures no leakage to host workstation"
     ],
     "passes": false
+  },
+  {
+    "category": "functional",
+    "description": "GitHub PAT Avatar: session-wide PAT entry via modal + avatar component showing authenticated GitHub user",
+    "steps": [
+      "PatModal opens automatically on first visit to Function List Page when no PAT is stored in session",
+      "PatModal is dismissable — user can close it without entering a PAT",
+      "PatModal validates the PAT against GitHub API and on success stores it in session and closes",
+      "SourceControlService interface extended with init(pat: string) and isInitialized(): boolean methods; GithubService implementation updated accordingly",
+      "UserAvatar component renders inside ListPageHeader at the top-right corner on every page (list, create, edit)",
+      "UserAvatar has two states: not initialized shows 'Connect to GitHub' with a key/lock icon (clickable, opens PatModal); initialized shows GitHub username with avatar icon",
+      "UserAvatar is clickable only on the Function List Page, clicking reopens PatModal to change the PAT and associated GitHub user",
+      "On Create and Edit pages, UserAvatar displays the GitHub user but is not clickable (PAT cannot be changed from those pages)",
+      "When PatModal is dismissed without a PAT, the Function List Page (both empty state and table view) shows a hint text directing the user to click 'Connect to GitHub' in the top-right corner to set a PAT",
+      "PAT change logic is encapsulated in a useUserAvatar custom hook following layered architecture (Hook imports Service, Component imports Hook)"
+    ],
+    "passes": false
+  },
+  {
+    "category": "functional",
+    "description": "Function List Page shows deployed functions from all user-accessible namespaces without requiring a PAT",
+    "steps": [
+      "ClusterService refactored: remove ALL_NAMESPACES and useActiveNamespace logic, always watch across all user-accessible namespaces (functions in GitHub repos can target different namespaces via func.yaml, so single-namespace view is not useful; filtering deferred to a later feature)",
+      "ClusterService lists all namespaces/projects accessible to the logged-in user and watches Deployments with label function.knative.dev/name across all of them",
+      "Function List Page renders deployed functions even when no PAT has been entered (PatModal dismissed or not yet shown)",
+      "When PAT is later provided, repo data from SourceControlService is merged with already-visible deployed functions",
+      "Deployed functions without a matching repo still appear in the table with available cluster data (name, namespace, status, replicas, url)"
+    ],
+    "passes": false
+  },
+  {
+    "category": "technical",
+    "description": "PR #5 review cleanup: consolidate duplicate GitHub services, fix naming conventions, extract hooks per architecture guidelines",
+    "steps": [
+      "Merge src/services/github/ into src/services/source-control/, combine OctokitGitHubService push logic into GithubService, remove src/services/github/ directory entirely",
+      "Rename GitHubService interface to SourceControlService and add push method to the existing SourceControlService interface (rename pushFiles to push per design doc)",
+      "Rename useGitHubService hook to useSourceControlService",
+      "Rename BackendFunctionService.ts to FunctionBackendService.ts",
+      "Remove duplicate @octokit/rest from devDependencies in package.json (keep only the entry under dependencies)",
+      "Extract useFunctionCreatePage hook from FunctionCreatePage — move service calls into useEffect (both FunctionService and SourceControlService call external APIs), keep the component rendering-only",
+      "Extract useCreateFunctionForm hook from CreateFunctionForm — consolidate individual useState calls into a single fields state object with a setField(key, value) helper, derive isValid from fields, remove handleSubmit (call onSubmit(fields) directly)",
+      "Update design doc (2026-03-16-faas-poc-design.md) to reflect all renames and new method signatures"
+    ],
+    "passes": true
   }
 ]