fix: match deployment to latest ready revision

The merge logic used deployments.find() with the
function.knative.dev/name label to locate the Deployment
for each function. After a redeployment Knative keeps the
old Revision's Deployment (scaled to 0) alongside the new
one, and both carry the same label. find() returned the
old Deployment, so deriveStatus saw replicas=0 and reported
ScaledToZero instead of Running.

Use ksvc.status.latestReadyRevisionName to identify the
active Revision, then match the Deployment via its
serving.knative.dev/revision label. Falls back to the
original function-name match when no revision name is set
(initial deploy before any revision is ready).

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Matej Vašek <matejvasek@gmail.com>

Author: matejvasek

src/services/cluster/useClusterService.test.tsx

@@ -21,6 +21,7 @@ const mockKsvc = {
   },
   status: {
     url: 'https://my-func-demo.apps.example.com',
+    latestReadyRevisionName: 'my-func-00001',
     conditions: [{ type: 'Ready', status: 'True' }],
   },
 };
@@ -31,7 +32,10 @@ const mockDeployment = {
   metadata: {
     name: 'my-func-00001-deployment',
     namespace: 'demo',
-    labels: { 'function.knative.dev/name': 'my-func' },
+    labels: {
+      'function.knative.dev/name': 'my-func',
+      'serving.knative.dev/revision': 'my-func-00001',
+    },
   },
   spec: { replicas: 1 },
   status: { readyReplicas: 1 },

src/views/FunctionsListPage.test.tsx

@@ -83,6 +83,7 @@ function ksvcFixture(
   name: string,
   readyStatus: string,
   url = `https://${name}-demo.apps.example.com`,
+  revision = `${name}-00001`,
 ) {
   return {
     apiVersion: 'serving.knative.dev/v1',
@@ -94,19 +95,28 @@ function ksvcFixture(
     },
     status: {
       url,
+      latestReadyRevisionName: revision,
       conditions: [{ type: 'Ready', status: readyStatus }],
     },
   };
 }
 
-function deploymentFixture(name: string, specReplicas: number, readyReplicas: number) {
+function deploymentFixture(
+  name: string,
+  specReplicas: number,
+  readyReplicas: number,
+  revision = `${name}-00001`,
+) {
   return {
     apiVersion: 'apps/v1',
     kind: 'Deployment',
     metadata: {
-      name: `${name}-00001-deployment`,
+      name: `${revision}-deployment`,
       namespace: 'demo',
-      labels: { 'function.knative.dev/name': name },
+      labels: {
+        'function.knative.dev/name': name,
+        'serving.knative.dev/revision': revision,
+      },
     },
     spec: { replicas: specReplicas },
     status: { readyReplicas },
@@ -381,6 +391,32 @@ describe('FunctionsListPage', () => {
     expect(await screen.findByTestId('fn-status')).toHaveTextContent('Error');
   });
 
+  it('picks latest revision deployment when multiple revisions exist', async () => {
+    renderAuthenticated();
+    mockUseSourceControl.mockReturnValue({
+      listFunctionRepos: vi.fn().mockResolvedValue([repoFixture('my-func')]),
+      fetchFileContent: vi.fn().mockResolvedValue('name: my-func\nruntime: go\nnamespace: demo\n'),
+    });
+    mockUseClusterService.mockReturnValue(
+      clusterData({
+        knativeServices: [ksvcFixture('my-func', 'True', undefined, 'my-func-00002')],
+        deployments: [
+          deploymentFixture('my-func', 0, 0, 'my-func-00001'),
+          deploymentFixture('my-func', 1, 1, 'my-func-00002'),
+        ],
+      }),
+    );
+
+    render(
+      <MemoryRouter>
+        <FunctionsListPage />
+      </MemoryRouter>,
+    );
+
+    expect(await screen.findByTestId('fn-status')).toHaveTextContent('Running');
+    expect(screen.getByTestId('fn-replicas')).toHaveTextContent('1');
+  });
+
   it('passes function names to useClusterService', async () => {
     renderAuthenticated();
     mockUseSourceControl.mockReturnValue({

src/views/FunctionsListPage.tsx

@@ -161,9 +161,14 @@ function useFunctionListPage(): {
         const ksvc = knativeServices.find(
           (s) => s.metadata?.labels?.['function.knative.dev/name'] === item.name,
         );
-        const deployment = deployments.find(
-          (d) => d.metadata?.labels?.['function.knative.dev/name'] === item.name,
-        );
+        const latestRevision = ksvc?.status?.latestReadyRevisionName;
+        const deployment = latestRevision
+          ? deployments.find(
+              (d) => d.metadata?.labels?.['serving.knative.dev/revision'] === latestRevision,
+            )
+          : deployments.find(
+              (d) => d.metadata?.labels?.['function.knative.dev/name'] === item.name,
+            );
         return ksvc && deployment ? enrichItem(item, ksvc, deployment) : item;
       }),
     [functionItems, knativeServices, deployments],