This repository was archived by the owner on Jun 26, 2026. It is now read-only.
Feat: Better testing server setup for init.sh#25
Merged
Conversation
matejvasek
force-pushed
the
improve-test-cluster
branch
2 times, most recently
from
May 18, 2026 16:00
dbc8e9a to
258eb37
Compare
twoGiants
suggested changes
May 18, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @matejvasek ! This is very useful. I have only small comments. See below.
twoGiants
suggested changes
May 20, 2026
matejvasek
added a commit
that referenced
this pull request
May 20, 2026
- Move plan to docs/plans/completed/ - Move design spec to docs/designs/ - Mark init.sh feature as passes:true in features.json - Document inotify-tools as optional dev prerequisite in README - Handle errserver startup failure: log, stop_dev, exit watcher Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
I addressed PR feedback in latest commit. |
twoGiants
suggested changes
May 20, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
I have a last one with the help of Claude.
twoGiants
approved these changes
May 20, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thank you for the re-work.
You can merge after addressing the last comment.
- Stop operations use PID files (.dev-pids/) with recursive kill_tree instead of pgrep/pkill, handles deep process trees (e.g. yarn->webpack) - Ports randomized via --randomize-ports flag (default ports unchanged) - Active ports written to .dev-env.json for agent and tooling discovery - Go backend auto-recompiles on .go/.mod/.sum changes via inotifywait with build-then-swap strategy (build to tmp, swap only on success) - On compilation failure, errserver returns HTTP 500 with build error as JSON so the UI displays actual compiler output - Watcher shuts down on inotifywait or errserver startup failure - start-console.sh accepts --backend-port, --plugin-port, --console-port, --cidfile CLI args - Dropped --network=host on Linux, uses -p port mapping everywhere - webpack.config.ts reads PLUGIN_PORT env var with fallback to 9001 - Agent docs (AGENTS.md, WORKFLOW.md, init-session) reference .dev-env.json and .dev-logs/ - inotify-tools documented as optional dev prerequisite in README Signed-off-by: Matej Vašek <matejvasek@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
matejvasek
force-pushed
the
improve-test-cluster
branch
from
May 20, 2026 13:49
808f5d4 to
c55181c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.dev-pids/) with recursivekill_treeinstead ofpgrep/pkill--randomize-portsflag allocates unique random ports for backend, plugin, and console (default ports unchanged).dev-env.jsonfor agent and tooling discovery.go/.mod/.sumchanges viainotifywait(build-then-swap, graceful degradation if not installed)start-console.shaccepts--backend-port,--plugin-port,--console-port,--cidfileCLI args--network=hoston Linux in favor of-pport mapping (enables console port randomization)webpack.config.tsreadsPLUGIN_PORTenv var with fallback to 9001.dev-env.jsonand.dev-logs/