Skip to content

Commit c4d6c31

Browse files
authored
Merge pull request #109 from mattrent/fixes
Fixes
2 parents 4d6d6a6 + b25b3d5 commit c4d6c31

7 files changed

Lines changed: 20 additions & 8 deletions

File tree

internal/command/fn/fn.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
package fn
1616

1717
import (
18+
"bytes"
1819
"encoding/json"
1920
"errors"
2021

@@ -42,7 +43,11 @@ func extractError(err error) error {
4243
if !castOk {
4344
return err
4445
}
45-
if err := json.Unmarshal(openApiError.Body(), &e); err != nil {
46+
47+
d := json.NewDecoder(bytes.NewReader(openApiError.Body()))
48+
d.DisallowUnknownFields()
49+
50+
if err := d.Decode(&e); err != nil {
4651
return err
4752
}
4853
return errors.New(e.Errors.Detail)

internal/command/mod/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (c *Create) Run(ctx context.Context, modHandler client.ModHandler, logger l
2929
err := modHandler.Create(ctx, c.Name)
3030

3131
if err != nil {
32-
return err
32+
return extractError(err)
3333
}
3434

3535
logger.Infof("Successfully created module %s.\n", c.Name)

internal/command/mod/delete.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (d *Delete) Run(ctx context.Context, modHandler client.ModHandler, logger l
2929
err := modHandler.Delete(ctx, d.Name)
3030

3131
if err != nil {
32-
return err
32+
return extractError(err)
3333
}
3434

3535
logger.Infof("Successfully deleted module %s.\n", d.Name)

internal/command/mod/get.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func (g *Get) Run(ctx context.Context, modHandler client.ModHandler, logger log.
3737
functions := data.Functions
3838

3939
if err != nil {
40-
return err
40+
return extractError(err)
4141
}
4242
logger.Infof("Module: %s\n", *name)
4343
logger.Info("Functions:")

internal/command/mod/mod.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
package mod
1616

1717
import (
18+
"bytes"
1819
"encoding/json"
1920
"errors"
2021

@@ -42,7 +43,11 @@ func extractError(err error) error {
4243
if !castOk {
4344
return err
4445
}
45-
if err := json.Unmarshal(openApiError.Body(), &e); err != nil {
46+
47+
d := json.NewDecoder(bytes.NewReader(openApiError.Body()))
48+
d.DisallowUnknownFields()
49+
50+
if err := d.Decode(&e); err != nil {
4651
return err
4752
}
4853
return errors.New(e.Errors.Detail)

internal/command/mod/update.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func (u *Update) Run(ctx context.Context, modHandler client.ModHandler, logger l
3030
err := modHandler.Update(ctx, u.Name, u.NewName)
3131

3232
if err != nil {
33-
return err
33+
return extractError(err)
3434
}
3535

3636
logger.Infof("Successfully renamed module %s to %s.\n", u.Name, u.NewName)

pkg/build/wasm.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ package build
1717
import (
1818
"context"
1919
"errors"
20+
"fmt"
2021
"os"
2122
"path/filepath"
23+
"time"
2224

2325
"github.com/docker/docker/api/types/container"
2426
"github.com/docker/docker/api/types/mount"
@@ -61,11 +63,11 @@ func (b *WasmBuilder) Setup(flDocker docker.DockerClient, language string, dest
6163
}
6264
b.builderImg = lang.BuilderImage
6365

64-
containerName, exists := builderNames[language]
66+
containerBaseName, exists := builderNames[language]
6567
if !exists {
6668
return errors.New("no corresponding builder name found for the given language")
6769
}
68-
b.builderContainerName = containerName
70+
b.builderContainerName = containerBaseName + fmt.Sprintf("%d", time.Now().UnixMilli())
6971
b.flDocker = flDocker
7072
b.outPath = dest
7173

0 commit comments

Comments
 (0)