Summary
I propose we change IEnumerable<TEntity> to ICollection<TEntity> on the methods which have the entities.ToList()

My thoughts are:
Solutions:
1.) Change to IAsynEnumerable
or
2.) Use ICollection instead if IEnumerable
Which do you think would be better?
- For the non-async methods, option 2 is the only solution
- For the async methods, both option 1 and 2 can be applied
Should I make these changes? What are your thoughts on option 1 or 2?
Summary
I propose we change
IEnumerable<TEntity>toICollection<TEntity>on the methods which have theentities.ToList()My thoughts are:
.ToList()so we lose all advantages IEnumerable could offernetstandard2.1notnetstandard2.0unless if they perform these steps https://btburnett.com/csharp/2019/12/01/iasyncenumerable-is-your-friend.htmlSolutions:
1.) Change to IAsynEnumerable
or
2.) Use
ICollectioninstead ifIEnumerableWhich do you think would be better?
Should I make these changes? What are your thoughts on option 1 or 2?